Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Quality Gate #964

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 2, 2023

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

Copy link

github-actions bot commented Dec 2, 2023

Test Results

     270 files  ±0       270 suites  ±0   42m 17s ⏱️ -16s
  3 327 tests ±0    3 297 ✔️ ±0  30 💤 ±0  0 ±0 
10 278 runs  ±0  10 188 ✔️ ±0  90 💤 ±0  0 ±0 

Results for commit 00ae3b8. ± Comparison against base commit e9e9558.

@jukzi
Copy link
Contributor

jukzi commented Dec 2, 2023

lets try

@jukzi jukzi merged commit 509d301 into eclipse-pde:master Dec 2, 2023
16 checks passed
@HannesWell HannesWell mentioned this pull request Dec 2, 2023
@vogella
Copy link
Contributor

vogella commented Dec 2, 2023

Hammer! Please also add this check to platform repos. Finally an automatic way to prevent warning creep

@laeubi
Copy link
Contributor Author

laeubi commented Dec 6, 2023

Hammer! Please also add this check to platform repos.

As usually from then on each and every inconvenience with failing builds due to such quality checks are blamed on the messenger (aka committer of the config change) its unlikely I'll roll this out to the large, but the change is simple enough for anyone that finds it important enough for their project they fell confident enough to apply it anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants