Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE Jenkins build broken, API tools report errors #888

Closed
iloveeclipse opened this issue Nov 6, 2023 · 19 comments
Closed

PDE Jenkins build broken, API tools report errors #888

iloveeclipse opened this issue Nov 6, 2023 · 19 comments
Assignees
Labels
bug Something isn't working regression Regression defect
Milestone

Comments

@iloveeclipse
Copy link
Member

See

15:44:12  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.4-SNAPSHOT:verify (verify) on project org.eclipse.pde.build: There are API errors:
15:44:12  [ERROR] src/org/eclipse/pde/build/Constants.java:21 The type org.eclipse.pde.build.Constants has been removed from org.eclipse.pde.build_3.12.200
15:44:12  [ERROR] src/org/eclipse/pde/build/IAntScript.java:27 The type org.eclipse.pde.build.IAntScript has been removed from org.eclipse.pde.build_3.12.200
15:44:12  [ERROR] src/org/eclipse/pde/build/IFetchFactory.java:50 The type org.eclipse.pde.build.IFetchFactory has been removed from org.eclipse.pde.build_3.12.200
15:44:12  [ERROR] META-INF/MANIFEST.MF:5 The major version should be incremented in version 3.12.200, since API breakage occurred since version 3.12.100
15:44:12  [ERROR] -> [Help 1]
@iloveeclipse iloveeclipse added bug Something isn't working regression Regression defect labels Nov 6, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.pde.ui that referenced this issue Nov 6, 2023
This doesn't fix the problem, but may be gives some hints

See eclipse-pde#888
iloveeclipse added a commit that referenced this issue Nov 6, 2023
This doesn't fix the problem, but may be gives some hints

See #888
@iloveeclipse
Copy link
Member Author

@laeubi : do you see anything useful in https://ci.eclipse.org/pde/job/eclipse.pde/job/PR-887/2/console ?

This reminds me on #782.
Is this Tycho fix may be not working for PDE for some reason?

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

The debug output looks normal:

[2023-11-06T16:15:46.825Z] [INFO] Resolve API tools runtime from MavenRepositoryLocation [location=https://download.eclipse.org/eclipse/updates/4.30-I-builds/]...
[2023-11-06T16:15:50.158Z] API Tools version: 1.3.200.v20231102-1258
[2023-11-06T16:15:50.158Z] Job Load Target Platform(24) scheduled...
[2023-11-06T16:15:50.158Z] Job Load Target Platform(24) aboutToRun...
[2023-11-06T16:15:50.158Z] Job Load Target Platform(24) running...
[2023-11-06T16:15:50.158Z] Job Updating workspace(6) scheduled...
[2023-11-06T16:15:50.158Z] Job Re-resolve Target state after VM-Install or EE change(25) scheduled...
[2023-11-06T16:15:50.158Z] Job Re-resolve Target state after VM-Install or EE change(25) done...
[2023-11-06T16:15:50.158Z] Job Re-resolve Target state after VM-Install or EE change(26) scheduled...
[2023-11-06T16:15:50.158Z] Job Update Installed JREs(27) scheduled...
[2023-11-06T16:15:50.158Z] Job Update Installed JREs(27) aboutToRun...
[2023-11-06T16:15:50.158Z] Job Update Installed JREs(27) running...
[2023-11-06T16:15:50.158Z] Job Update Installed JREs(27) done...
[2023-11-06T16:15:50.158Z] Job Synchronizing projects(28) scheduled...
[2023-11-06T16:15:50.159Z] Job Synchronizing projects(28) aboutToRun...
[2023-11-06T16:15:50.159Z] Job Synchronizing projects(28) running...
[2023-11-06T16:15:50.159Z] Job Synchronizing projects(28) done...
[2023-11-06T16:15:50.159Z] Job Re-resolve Target state after VM-Install or EE change(26) aboutToRun...
[2023-11-06T16:15:50.159Z] Job Re-resolve Target state after VM-Install or EE change(26) running...
[2023-11-06T16:15:51.124Z] Job Load Target Platform(24) done...
[2023-11-06T16:15:51.124Z] Job Building(4) sleeping...
[2023-11-06T16:15:51.124Z] Job Updating workspace(6) done...
[2023-11-06T16:15:51.124Z] Job Re-resolve Target state after VM-Install or EE change(26) done...
[2023-11-06T16:15:51.124Z] Job Flushing content description cache.(11) scheduled...
[2023-11-06T16:15:51.124Z] Job Periodic workspace save.(7) scheduled...
[2023-11-06T16:15:51.124Z] Job Periodic workspace save.(7) aboutToRun...
[2023-11-06T16:15:51.124Z] Job Periodic workspace save.(7) running...
[2023-11-06T16:15:51.124Z] Job Periodic workspace save.(7) done...
[2023-11-06T16:15:51.124Z] Job Reporting encoding changes.(9) scheduled...
[2023-11-06T16:15:51.124Z] Job Updating workspace(6) scheduled...
[2023-11-06T16:15:51.124Z] Job Updating workspace(6) done...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) running...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) done...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) running...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) done...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) running...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) done...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) running...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) done...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:51.124Z] Job Updating index names(16) running...
[2023-11-06T16:15:51.381Z] Job Periodic workspace save.(7) scheduled...
[2023-11-06T16:15:51.381Z] Job Building(4) aboutToRun...
[2023-11-06T16:15:51.381Z] Job Building(4) running...
[2023-11-06T16:15:51.381Z] Job Updating index names(16) done...
[2023-11-06T16:15:51.381Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:51.381Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:51.381Z] Job Updating index names(16) running...
[2023-11-06T16:15:51.381Z] Job Updating index names(16) done...
[2023-11-06T16:15:51.381Z] Job Building(4) done...
[2023-11-06T16:15:51.381Z] Job Sending build events with disabled autobuild(5) scheduled...
[2023-11-06T16:15:51.639Z] Project component was found
[2023-11-06T16:15:51.639Z] ==== [bundle] Plug-in Development Environment Build Support - baseline ====
[2023-11-06T16:15:51.639Z] bcpg 1.76.0 -- bcpg-1.76.0.jar
[2023-11-06T16:15:51.639Z] bcprov 1.76.0 -- bcprov-1.76.0.jar
[2023-11-06T16:15:51.639Z] org.eclipse.ant.core 3.7.100 -- org.eclipse.ant.core-3.7.100.v20230731-0828.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.variables 3.6.100 -- org.eclipse.core.variables-3.6.100.v20230726-0617.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.runtime 3.29.0 -- org.eclipse.core.runtime-3.29.0.v20230726-0617.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.commands 3.11.100 -- org.eclipse.core.commands-3.11.100.v20230708-0916.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.common 3.18.100 -- org.eclipse.equinox.common-3.18.100.v20230730-1117.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.contenttype 3.9.100 -- org.eclipse.core.contenttype-3.9.100.v20230630-1232.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.preferences 3.10.300 -- org.eclipse.equinox.preferences-3.10.300.v20230630-1303.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.registry 3.11.300 -- org.eclipse.equinox.registry-3.11.300.v20230801-1826.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.expressions 3.9.100 -- org.eclipse.core.expressions-3.9.100.v20230726-0617.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.filesystem 1.10.100 -- org.eclipse.core.filesystem-1.10.100.v20230717-1727.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.jobs 3.15.0 -- org.eclipse.core.jobs-3.15.0.v20230808-1403.jar
[2023-11-06T16:15:51.639Z] org.eclipse.core.resources 3.19.100 -- org.eclipse.core.resources-3.19.100.v20230814-1312.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.app 1.6.300 -- org.eclipse.equinox.app-1.6.300.v20230630-1303.jar
[2023-11-06T16:15:51.639Z] org.eclipse.debug.core 3.21.100 -- org.eclipse.debug.core-3.21.100.v20230731-1425.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.frameworkadmin 2.2.200 -- org.eclipse.equinox.frameworkadmin-2.2.200.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.frameworkadmin.equinox 1.2.400 -- org.eclipse.equinox.frameworkadmin.equinox-1.2.400.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.artifact.repository 1.5.100 -- org.eclipse.equinox.p2.artifact.repository-1.5.100.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.metadata 2.7.100 -- org.eclipse.equinox.p2.metadata-2.7.100.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.tukaani.xz 1.9.0 -- org.tukaani.xz-1.9.0.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.core 2.10.100 -- org.eclipse.equinox.p2.core-2.10.100.v20230814-2013.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.jarprocessor 1.3.200 -- org.eclipse.equinox.p2.jarprocessor-1.3.200.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.repository 2.7.100 -- org.eclipse.equinox.p2.repository-2.7.100.v20230710-0621.jar
[2023-11-06T16:15:51.639Z] org.osgi.service.prefs 1.1.2 -- org.osgi.service.prefs-1.1.2.202109301733.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.engine 2.8.100 -- org.eclipse.equinox.p2.engine-2.8.100.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.metadata.repository 1.5.100 -- org.eclipse.equinox.p2.metadata.repository-1.5.100.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.publisher 1.8.100 -- org.eclipse.equinox.p2.publisher-1.8.100.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.p2.publisher.eclipse 1.5.100 -- org.eclipse.equinox.p2.publisher.eclipse-1.5.100.v20230814-2013.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.simpleconfigurator.manipulator 2.2.200 -- org.eclipse.equinox.simpleconfigurator.manipulator-2.2.200.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.security 1.4.0 -- org.eclipse.equinox.security-1.4.0.v20230630-1303.jar
[2023-11-06T16:15:51.639Z] org.eclipse.equinox.simpleconfigurator 1.4.300 -- org.eclipse.equinox.simpleconfigurator-1.4.300.v20230630-1506.jar
[2023-11-06T16:15:51.639Z] org.eclipse.jdt.core 3.35.0 -- org.eclipse.jdt.core-3.35.0.v20230814-1356.jar
[2023-11-06T16:15:51.639Z] org.eclipse.text 3.13.100 -- org.eclipse.text-3.13.100.v20230801-1334.jar
[2023-11-06T16:15:51.639Z] org.eclipse.jdt.core.compiler.batch 3.35.0 -- org.eclipse.jdt.core.compiler.batch-3.35.0.v20230814-2020.jar
[2023-11-06T16:15:51.639Z] org.eclipse.jdt.debug 3.21.100 -- org.eclipse.jdt.debug-3.21.100.v20230728-0612.jar
[2023-11-06T16:15:51.639Z] org.eclipse.jdt.launching 3.20.100 -- org.eclipse.jdt.launching-3.20.100.v20230814-1810.jar
[2023-11-06T16:15:51.639Z] org.eclipse.pde.build 3.12.100 -- org.eclipse.pde.build-3.12.100.v20230825-1354.jar
[2023-11-06T16:15:51.639Z] Job Reporting encoding changes.(9) aboutToRun...
[2023-11-06T16:15:51.639Z] Job Reporting encoding changes.(9) running...
[2023-11-06T16:15:51.639Z] System Component:
[2023-11-06T16:15:51.639Z] 	Version: JavaSE-17
[2023-11-06T16:15:51.639Z] 	Location: /opt/tools/java/temurin/jdk-17/jdk-17.0.9+9
[2023-11-06T16:15:51.639Z] 	Execution Environment: JavaSE-17
[2023-11-06T16:15:51.639Z] Job Java indexing... (36) scheduled...
[2023-11-06T16:15:51.639Z] Job Java indexing... (36) aboutToRun...
[2023-11-06T16:15:51.639Z] Job Java indexing... (36) running...
[2023-11-06T16:15:51.956Z] Job Flushing content description cache.(11) aboutToRun...
[2023-11-06T16:15:51.956Z] Job Flushing content description cache.(11) running...
[2023-11-06T16:15:53.457Z] API problem: src/org/eclipse/pde/build/Constants.java
[2023-11-06T16:15:53.457Z] 	severity: ERROR
[2023-11-06T16:15:53.457Z] 	category: COMPATIBILITY
[2023-11-06T16:15:53.457Z] 	element kind: API_COMPONENT_ELEMENT_TYPE
[2023-11-06T16:15:53.457Z] 	kind: REMOVED
[2023-11-06T16:15:53.457Z] 	flags: TYPE
[2023-11-06T16:15:53.457Z] 	message id: 102
[2023-11-06T16:15:53.457Z] 	message: The type org.eclipse.pde.build.Constants has been removed from org.eclipse.pde.build_3.12.200
[2023-11-06T16:15:53.457Z] API problem: src/org/eclipse/pde/build/IAntScript.java
[2023-11-06T16:15:53.457Z] 	severity: ERROR
[2023-11-06T16:15:53.457Z] 	category: COMPATIBILITY
[2023-11-06T16:15:53.457Z] 	element kind: API_COMPONENT_ELEMENT_TYPE
[2023-11-06T16:15:53.457Z] 	kind: REMOVED
[2023-11-06T16:15:53.457Z] 	flags: TYPE
[2023-11-06T16:15:53.457Z] 	message id: 102
[2023-11-06T16:15:53.457Z] 	message: The type org.eclipse.pde.build.IAntScript has been removed from org.eclipse.pde.build_3.12.200
[2023-11-06T16:15:53.457Z] API problem: src/org/eclipse/pde/build/IFetchFactory.java
[2023-11-06T16:15:53.457Z] 	severity: ERROR
[2023-11-06T16:15:53.457Z] 	category: COMPATIBILITY
[2023-11-06T16:15:53.457Z] 	element kind: API_COMPONENT_ELEMENT_TYPE
[2023-11-06T16:15:53.457Z] 	kind: REMOVED
[2023-11-06T16:15:53.457Z] 	flags: TYPE
[2023-11-06T16:15:53.457Z] 	message id: 102
[2023-11-06T16:15:53.457Z] 	message: The type org.eclipse.pde.build.IFetchFactory has been removed from org.eclipse.pde.build_3.12.200
[2023-11-06T16:15:53.457Z] API problem: META-INF/MANIFEST.MF
[2023-11-06T16:15:53.457Z] 	severity: ERROR
[2023-11-06T16:15:53.457Z] 	category: VERSION
[2023-11-06T16:15:53.457Z] 	element kind: RESOURCE
[2023-11-06T16:15:53.457Z] 	kind: MAJOR_VERSION_CHANGE
[2023-11-06T16:15:53.457Z] 	flags: NO_FLAGS
[2023-11-06T16:15:53.457Z] 	message id: 5
[2023-11-06T16:15:53.457Z] 	message: The major version should be incremented in version 3.12.200, since API breakage occurred since version 3.12.100
[2023-11-06T16:15:53.457Z] API problem: src/org/eclipse/pde/internal/build/AntLogAdapter.java
[2023-11-06T16:15:53.457Z] 	severity: WARNING
[2023-11-06T16:15:53.457Z] 	category: USAGE
[2023-11-06T16:15:53.457Z] 	element kind: REFERENCE_TYPE
[2023-11-06T16:15:53.457Z] 	kind: UNUSED_PROBLEM_FILTERS
[2023-11-06T16:15:53.457Z] 	flags: NO_FLAGS
[2023-11-06T16:15:53.457Z] 	message id: 30
[2023-11-06T16:15:53.457Z] 	message: The API problem filter for: 'AntLogAdapter illegally implements ILog' is no longer used
[2023-11-06T16:15:53.457Z] Job Reporting encoding changes.(9) done...
[2023-11-06T16:15:53.457Z] Job Updating workspace(6) scheduled...
[2023-11-06T16:15:53.457Z] Job Updating workspace(6) done...
[2023-11-06T16:15:53.457Z] Job Flushing content description cache.(11) done...
[2023-11-06T16:15:53.457Z] Job Periodic workspace save.(7) done...
[2023-11-06T16:15:53.457Z] Job Sending build events with disabled autobuild(5) aboutToRun...
[2023-11-06T16:15:53.457Z] Job Sending build events with disabled autobuild(5) running...
[2023-11-06T16:15:53.714Z] Job Sending build events with disabled autobuild(5) done...
[2023-11-06T16:15:53.714Z] Job Sending build events with disabled autobuild(5) scheduled...
[2023-11-06T16:15:53.714Z] Job Registry event dispatcher(40) scheduled...
[2023-11-06T16:15:53.714Z] Job Registry event dispatcher(40) aboutToRun...
[2023-11-06T16:15:53.714Z] Job Registry event dispatcher(40) running...
[2023-11-06T16:15:53.714Z] Job Registry event dispatcher(40) done...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) running...
[2023-11-06T16:15:53.714Z] Job Sending build events with disabled autobuild(5) aboutToRun...
[2023-11-06T16:15:53.714Z] Job Sending build events with disabled autobuild(5) running...
[2023-11-06T16:15:53.714Z] Job Sending build events with disabled autobuild(5) done...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) done...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) scheduled...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) aboutToRun...
[2023-11-06T16:15:53.714Z] Job Java indexing... 140 files to index (/opt/tools/java/temurin/jdk-17/jdk-17.0.9+9/lib/jrt-fs.jar)(36) done...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) running...
[2023-11-06T16:15:53.714Z] Job Updating index names(16) done...
[2023-11-06T16:15:57.960Z] Job Compacting resource model(14) done...

so maybe the project is special (e.g. unusual output folders, ant involved, ...)

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Nov 6, 2023

Looking at the pde.build bundle, I see that it is built/deployed as a directory (not as jar), and the classes that API tools is missing are inside a jar inside the directory. So I wonder if the tycho build fails to consider that jar during API analysis?

image

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

I think the missing "magic" might either be source.lib/pdebuild-ant.jar or jars.extra.classpath = platform:/plugin/org.apache.ant/lib/ant.jar, platform:/plugin/org.eclipse.equinox.p2.repository.tools/lib/repository-tools-ant.jar or both in combination...

@iloveeclipse
Copy link
Member Author

Or that the tycho uses wrong output folder, while project has two output folders configured:

image

I mean this line:

https://github.com/laeubi/tycho/blob/ae7bca96e64f6372608a277a65bf0d5bf774daa9/tycho-apitools-plugin/src/main/java/org/eclipse/tycho/apitools/ApiAnalysis.java#L191

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

source.lib/pdebuild-ant.jar will be compiled to a separate folder (but not bin_ant) so I need to enhance my fix to additional folders as specified in output.lib/pdebuild-ant.jar = bin_ant/ will try to provide a fix tomorrow, this build setup is a bit odd ...

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

Okay it is not actually the ant_bin to blame here, BUT the build is configuring

source.pdebuild.jar = src/
output.pdebuild.jar = bin/

in contrast to a "usual"

source.. = src/
output.. = bin/

this results in a complete empty target/classes directory and instead everything compiled to target/pdebuild.jar-classes instead...

@iloveeclipse
Copy link
Member Author

BUT the build is configuring

Yes, because the classes will go in a dedicated jar in the bundle directory, not in the "usual" jar.

@iloveeclipse
Copy link
Member Author

We have few platform bundles that do that, if I remember it right. Ant/debug etc bundles that need dedicated jars.

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

Yes but these jars are not then embedded and exported as API :-\

@iloveeclipse
Copy link
Member Author

Why not, it was/is fully transparent from OSGI point of view how bundle supplies API packages.

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

Why not, it was/is fully transparent from OSGI point of view how bundle supplies API packages.

Because API Tools != OSGi, if API tools would be able to work on the OSGi jar we won't have any problems her and elsewhere, see these open issues:

@iloveeclipse
Copy link
Member Author

if API tools would be able to work on the OSGi jar

API Tooling allows you to get API analysis without OSGI supplying the classes, immediately on the workspace build. This is a nice feature, otherwise one would need to run a full deployment cycle (building and packaging bundle) on every change in the IDE.

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2023

Here we have a jar and can't use it what makes things quite worse as we actually not check what is deployed and we must "emulate" the final jar..

Anyways I think I got a fix, but noticed that this dirty the .classpath files, is there a way to tel JDT not persist changes to .classpath but only "virtual"?

@iloveeclipse
Copy link
Member Author

way to tel JDT not persist changes to .classpath but only "virtual"?

Not that I know, but my knowledge is surely limited. But looking at what the patch is doing, why do you change project classpath at all - is this because you don't want to build the imported project? Wouldn't be easier to keep default settings and build it? Or, as you commented, if you are goimg to fake everything to make PDE consume pre-built classes, why not copy the "faked" project to a temp location?

@laeubi
Copy link
Contributor

laeubi commented Nov 7, 2023

is this because you don't want to build the imported project?

correct

Wouldn't be easier to keep default settings and build it?

Building the project is very time consuming, beside that it has lead to unpredictable behavior in the past as usually there is no way to say "only compile this", there are maybe other Builders involved what the can trigger things that might result in another compilation and then we see these instabilities we also have with the PDE tests itself.

Or, as you commented, if you are goimg to fake everything to make PDE consume pre-built classes, why not copy the "faked" project to a temp location?

That was my first idea, but copy large projects can again take time and therefore modify some config file to point to the right location seems a bit less intrusive, for example the IProject itself can be modified in memory what works quite well.

@laeubi
Copy link
Contributor

laeubi commented Nov 7, 2023

Fix for this is on the pipeline and should approach in about 2hrs:

@iloveeclipse
Copy link
Member Author

Great, thanks!

@iloveeclipse
Copy link
Member Author

Build succeeded: #886. Thanks, closing.

@iloveeclipse iloveeclipse added this to the 4.30 M3 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Regression defect
Projects
None yet
Development

No branches or pull requests

2 participants