PDE API-Tools should add api.tools.annotations on a Plug-ins classpath automatically

[HannesWell]

In order to use the PDE API-Tools annotations they have to be added from the current TP to the classpath of a Plugin by either Import-Package, Required-Bundle in the MANIFEST.MF or as additional.bundles in the build.properties. The latter is used by the ApiQuickFixProcessor, when converting the api-tools javadoc tags to annotations because it does not introduce a dependency at runtime (the annotations are only processed at build time).

In order to make using api-tools annotations even simpler the annotation should be added to a Plug-ins classpath using a IClasspathContributor created by the api-tools nature or builder. Then the a entry like additional.bundles = org.eclipse.pde.api.tools.annotations in the build.properties or even worse a entry in the MANIFEST.MF is not necessary anymore.
We already use that for the OSGiAnnotationsClasspathContributor and it works quite well.

If PDE supports that we have to check that Tycho supports that as well, but since Tycho just uses PDE's APIFileGenerator we can do that in PDE as well.

[laeubi]

If PDE supports that we have to check that Tycho supports that as well, but since Tycho just uses PDE's APIFileGenerator we can do that in PDE as well.

Tycho has a similar concept an the tycho-apitools-plugin must just provide a (plexus)component that extends AbstractSpecificationClasspathContributor to automatically enable this.

[HannesWell]

In order to ease the usage of these annotations it would probably also be good to have a Quick-Fix and/or clean-up to replace the java-doc based annotations.

[laeubi]

In order to ease the usage of these annotations it would probably also be good to have a Quick-Fix and/or clean-up to replace the java-doc based annotations.

I would love to get open-rewrite working for that:

• Incompatibility with Maven Polyglot leads to ParseError openrewrite/rewrite-maven-plugin#649 (comment)

@timtebeek is currently investigate that for moderne.io and I'm currently investigate to have a JDT plugin for that:

• Support discovery / apply of OpenRewrite recipes eclipse-jdt/eclipse.jdt.ui#871
• Support generation of open rewrite snippet when performing refactorings eclipse-jdt/eclipse.jdt.ui#870