Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (almost) unused method from provisional IApiBaselineManager #1533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 27, 2024

The IApiBaselineManager contains a helper method
IApiBaselineManager#getWorkspaceComponent that is only used in one test. The method has the drawback that one can't distinguish the case if no baseline is set or the component is not found additionally it might later depend on a disposed component.

Because of that the method is now removed and the single reference changed accordingly.

@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
apitools/org.eclipse.pde.api.tools.tests/pom.xml
apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 181c6d98bdca4a0de775513c33940e21448a0ec5 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Fri, 27 Dec 2024 08:02:28 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF b/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
index a5e4d37b10..dc8dbfbf41 100644
--- a/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
+++ b/apitools/org.eclipse.pde.api.tools.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.pde.api.tools.tests
-Bundle-Version: 1.3.700.qualifier
+Bundle-Version: 1.3.800.qualifier
 Bundle-Vendor: %Bundle-Vendor
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.pde.api.tools;bundle-version="1.0.600",
diff --git a/apitools/org.eclipse.pde.api.tools.tests/pom.xml b/apitools/org.eclipse.pde.api.tools.tests/pom.xml
index 6239c235ae..0a7c6f8467 100644
--- a/apitools/org.eclipse.pde.api.tools.tests/pom.xml
+++ b/apitools/org.eclipse.pde.api.tools.tests/pom.xml
@@ -18,7 +18,7 @@
 		<relativePath>../../</relativePath>
 	</parent>
 	<artifactId>org.eclipse.pde.api.tools.tests</artifactId>
-	<version>1.3.700-SNAPSHOT</version>
+	<version>1.3.800-SNAPSHOT</version>
 	<packaging>eclipse-test-plugin</packaging>
 	<properties>
 		<defaultSigning-excludeInnerJars>true</defaultSigning-excludeInnerJars>
diff --git a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
index 7fbad0b9c6..73b6266936 100644
--- a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
+++ b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.api.tools;singleton:=true
-Bundle-Version: 1.3.600.qualifier
+Bundle-Version: 1.3.700.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

laeubi and others added 2 commits December 27, 2024 13:50
The IApiBaselineManager contains a helper method
IApiBaselineManager#getWorkspaceComponent that is only used in one test.
The method has the drawback that one can't distinguish the case if no
baseline is set or the component is not found additionally it might
later depend on a disposed component.

Because of that the method is now removed and the single reference
changed accordingly.
@laeubi laeubi force-pushed the deprecate_getwscomp branch from 9734f76 to 98ea07e Compare December 27, 2024 12:50
Copy link

Test Results

  273 files   -    12    273 suites   - 12   41m 19s ⏱️ - 10m 52s
3 586 tests ±    0  3 507 ✅  -     3   77 💤 + 1  2 ❌ +2 
7 920 runs   - 3 030  7 769 ✅  - 2 950  149 💤  - 82  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 98ea07e. ± Comparison against base commit 0b123e0.

This pull request skips 1 test.
org.eclipse.pde.build.internal.tests.p2.P2Tests ‑ offBug237662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants