Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if a workspace is disposed outside the manager #1532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 27, 2024

Currently one can obtain a workspace baseline and dispose it leading to hard to track errors.

This now fails if someone tries to dispose the baseline without using the manager.

@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 00ada602dc7db9c6eb5d08d4893c2dfac65428f0 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Fri, 27 Dec 2024 07:50:03 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
index 7fbad0b9c6..73b6266936 100644
--- a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
+++ b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.api.tools;singleton:=true
-Bundle-Version: 1.3.600.qualifier
+Bundle-Version: 1.3.700.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Dec 27, 2024

Test Results

   285 files  ±0     285 suites  ±0   48m 45s ⏱️ +19s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 145fa0f. ± Comparison against base commit 2c1860a.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the fail_if_disposed_ws_baseline branch from 8e24948 to 7c521f8 Compare December 27, 2024 08:38
@laeubi
Copy link
Contributor Author

laeubi commented Dec 27, 2024

One of the failing tests seem to be caused by this:

@laeubi laeubi force-pushed the fail_if_disposed_ws_baseline branch 2 times, most recently from 43cc51c to 59ea85b Compare December 27, 2024 13:24
Currently one can obtain a workspace baseline and dispose it leading to
hard to track errors.

This now fails if someone tries to dispose the baseline without using
the manager.
@laeubi laeubi force-pushed the fail_if_disposed_ws_baseline branch from 59ea85b to 145fa0f Compare December 27, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants