Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target Editor UI freeze / taking very long when refresh a target file #1523

Closed
laeubi opened this issue Dec 16, 2024 · 2 comments · Fixed by #1531
Closed

Target Editor UI freeze / taking very long when refresh a target file #1523

laeubi opened this issue Dec 16, 2024 · 2 comments · Fixed by #1531
Assignees
@laeubi
Labels
bug Something isn't working target editor

Comments

@laeubi
Copy link
Contributor

laeubi commented Dec 16, 2024

I added an example test.zip file which is somehow similar to our internal target file, just for the sake of reproducing the described problem.

  1. Start Eclipse
  2. Open the Progress View
  3. Open test.target with Target Editor
  4. wait until all is resolved (takes for e about 2 minutes)
  5. press Refresh Button (if you click somewhere you see the ui is frozen)
  6. i see the above described dialog, which then disappears
  7. the more you click, the more you see the dialog
  8. now i have this "ui freeze state" for about 4:30 minutes (i guess the repositories are resolved in the background)
  9. after that the target platform is resolved again (which is shown in the Progress View)
  10. all in all the refresh takes about 5min vs 2min of the initial resoving

Originally posted by @phermsdorf in #1513 (reply in thread)
@laeubi laeubi self-assigned this Dec 16, 2024
@laeubi laeubi added target editor bug Something isn't working labels Dec 16, 2024
laeubi added a commit to laeubi/eclipse.pde that referenced this issue Dec 20, 2024
@laeubi
Refresh targets in the background
511067d 
A target refresh operation is currently run in the UI thread as it
probably in the past where considered a fast operation. At least with P2
Updatesites this is no longer the case and we can'T really make any
valid assumptions on how other implementation might perform.

This now schedule the work into a background job and also cleanup the
code to reflect current code base. In addition to that, if a job is
already running, the user is asked to cancel it before perform other
actions.

Fix eclipse-pde#1523
@laeubi laeubi mentioned this issue Dec 20, 2024
Merged
laeubi added a commit to laeubi/eclipse.pde that referenced this issue Dec 20, 2024
@laeubi
Refresh targets in the background
b6fcf23 
A target refresh operation is currently run in the UI thread as it
probably in the past where considered a fast operation. At least with P2
Updatesites this is no longer the case and we can'T really make any
valid assumptions on how other implementation might perform.

This now schedule the work into a background job and also cleanup the
code to reflect current code base. In addition to that, if a job is
already running, the user is asked to cancel it before perform other
actions.

Fix eclipse-pde#1523
laeubi added a commit to laeubi/eclipse.pde that referenced this issue Dec 20, 2024
@laeubi
Refresh targets in the background
5c98a23 
A target refresh operation is currently run in the UI thread as it
probably in the past where considered a fast operation. At least with P2
Updatesites this is no longer the case and we can'T really make any
valid assumptions on how other implementation might perform.

This now schedule the work into a background job and also cleanup the
code to reflect current code base. In addition to that, if a job is
already running, the user is asked to cancel it before perform other
actions.

Fix eclipse-pde#1523
laeubi added a commit that referenced this issue Dec 20, 2024
@laeubi
Refresh targets in the background
1535dde 
A target refresh operation is currently run in the UI thread as it
probably in the past where considered a fast operation. At least with P2
Updatesites this is no longer the case and we can'T really make any
valid assumptions on how other implementation might perform.

This now schedule the work into a background job and also cleanup the
code to reflect current code base. In addition to that, if a job is
already running, the user is asked to cancel it before perform other
actions.

Fix #1523
@phermsdorf
Copy link

Great! Thanks a lot @laeubi .
I'll try it out next week with the nightly build.

@phermsdorf
Copy link

I tried it with the last nightly build and now the refresh button works as expected and there is no ui freeze anymore.
Thanks a lot and merry x-mas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laeubi laeubi

Labels
bug Something isn't working target editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refresh targets in the background laeubi/eclipse.pde
2 participants
@laeubi @phermsdorf