Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk21 com/sun/crypto/provider/DHKEM/Compliance Undetermined for -6756058909602679649 #17633

Closed
pshipton opened this issue Jun 21, 2023 · 10 comments · Fixed by ibmruntimes/openj9-openjdk-jdk21#97
Closed

jdk21 com/sun/crypto/provider/DHKEM/Compliance Undetermined for -6756058909602679649 #17633

pshipton opened this issue Jun 21, 2023 · 10 comments · Fixed by ibmruntimes/openj9-openjdk-jdk21#97
Assignees
@KostasTsiounis
Labels
comp:crypto jdk21 test excluded test failure
Milestone
Java 21 (0.42)

Comments

@pshipton
Copy link
Member

https://openj9-jenkins.osuosl.org/job/Grinder_testList_2/46/ - amac jdk21
com/sun/crypto/provider/DHKEM/Compliance.java

15:09:01  java.lang.RuntimeException: Undetermined for -6756058909602679649: expected true, was false
15:09:01  	at jdk.test.lib.Asserts.fail(Asserts.java:594)
15:09:01  	at jdk.test.lib.Asserts.assertTrue(Asserts.java:486)
15:09:01  	at Compliance.determined(Compliance.java:205)
15:09:01  	at Compliance.main(Compliance.java:53)
15:09:01  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
15:09:01  	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
15:09:01  	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
15:09:01  	at java.base/java.lang.Thread.run(Thread.java:1595)
@pshipton pshipton added this to the Java 21 milestone Jun 21, 2023
@pshipton
Copy link
Member Author

@jasonkatonica fyi

pshipton added a commit to pshipton/openjdk-tests that referenced this issue Jun 21, 2023
@pshipton
Exclude OpenJ9 jdk21 failures until they can be fixed
54f2d70 
Issues
eclipse-openj9/openj9#17630
eclipse-openj9/openj9#17632
eclipse-openj9/openj9#17633
eclipse-openj9/openj9#17634

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Jun 21, 2023
Merged
karianna pushed a commit to adoptium/aqa-tests that referenced this issue Jun 21, 2023
@pshipton
Exclude OpenJ9 jdk21 failures until they can be fixed (#4640)
21c8dd1 
Issues
eclipse-openj9/openj9#17630
eclipse-openj9/openj9#17632
eclipse-openj9/openj9#17633
eclipse-openj9/openj9#17634

Signed-off-by: Peter Shipton <[email protected]>
@keithc-ca keithc-ca mentioned this issue Jul 6, 2023
Merged
pshipton added a commit to pshipton/openjdk-tests that referenced this issue Aug 15, 2023
@pshipton
Unexclude com/sun/crypto/provider/DHKEM/Compliance
ca40993 
Issue eclipse-openj9/openj9#17633

Signed-off-by: Peter Shipton <[email protected]>
@pshipton
Copy link
Member Author

Still fails on the latest jdk21 OpenJ9.
Passes on the latest Temurin nightly build.

Passes on OpenJ9 with -Djdk.nativeXDHKeyGen=false

Tentatively setting as a blocker, unless we can explain why this failure doesn't matter.

@KostasTsiounis
Copy link
Contributor

The test creates two Random instances with a specific seed. It then uses them to create two sets of XDH keys and encapsulate them. The expectation is that the result will be the same, since the source of randomness is the same.

However, the Random instance is never used when using OpenSSL to perform operations (uses its own source of randomness), which leads to two consecutive calls providing two different results.

@0xdaryl
Copy link
Contributor

0xdaryl commented Sep 26, 2023

Kostas (@KostasTsiounis ), could you post a current status update on this blocking JDK 21 issue please? Thanks.

@KostasTsiounis
Copy link
Contributor

We are currently working on a fix for this issue.

@vij-singh
Copy link

@KostasTsiounis Any new news on this one?

@tajila
Copy link
Contributor

tajila commented Oct 23, 2023

@KostasTsiounis Any update?

@vij-singh
Copy link

A fix for this is still being worked

@pshipton pshipton removed the blocker label Oct 24, 2023
@KostasTsiounis KostasTsiounis mentioned this issue Dec 12, 2023
Merged
@pshipton
Copy link
Member Author

Keep it open until the test is unexcluded.

@pshipton pshipton reopened this Dec 12, 2023
pshipton added a commit to pshipton/openjdk-tests that referenced this issue Dec 12, 2023
@pshipton
Unexclude OpenJ9 OpenJDK com/sun/crypto/provider/DHKEM/Compliance.java
5c90be0 
Issue eclipse-openj9/openj9#17633

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Dec 12, 2023
Merged
pshipton added a commit to pshipton/openjdk-tests that referenced this issue Dec 12, 2023
@pshipton
Unexclude OpenJ9 OpenJDK com/sun/crypto/provider/DHKEM/Compliance.java
0938374 
Issue eclipse-openj9/openj9#17633

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Dec 12, 2023
Merged
@pshipton
Copy link
Member Author

Unexcluding via
adoptium/aqa-tests#4920
adoptium/aqa-tests#4921

llxia pushed a commit to adoptium/aqa-tests that referenced this issue Dec 12, 2023
@pshipton
Unexclude OpenJ9 OpenJDK com/sun/crypto/provider/DHKEM/Compliance.java (
686727d 
#4921)

Issue eclipse-openj9/openj9#17633

Signed-off-by: Peter Shipton <[email protected]>
LongyuZhang pushed a commit to adoptium/aqa-tests that referenced this issue Dec 12, 2023
@pshipton
Unexclude OpenJ9 OpenJDK com/sun/crypto/provider/DHKEM/Compliance.java (
4c1bf71 
#4920)

Issue eclipse-openj9/openj9#17633

Signed-off-by: Peter Shipton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KostasTsiounis KostasTsiounis

Labels
comp:crypto jdk21 test excluded test failure
Projects
None yet
Milestone
Java 21 (0.42)
Development

Successfully merging a pull request may close this issue.

Revert to Java impl when non-default SecureRandom present KostasTsiounis/openj9-openjdk-jdk21
5 participants
@tajila @0xdaryl @pshipton @vij-singh @KostasTsiounis