Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity.system ExplMod fails due to unexpected java.lang.IllegalAccessError message text #12315

Closed
lumpfish opened this issue Mar 29, 2021 · 1 comment · Fixed by #12325
Closed

Comments

@lumpfish
Copy link
Contributor

openj9's java.lang.IllegalAccessError message text differs from hotpot's, and that causes the ExplMod system test (currently excluded) to fail.

The test was presumably calibrated against hotspot, and while the text which accompanies an exception is up to the implementor to specify I assume openj9 would like to consider whether to make changes to its message before requesting that the test case be changed.

This is the openj9 exception message thrown when running the test:

java.lang.IllegalAccessError: Class net/adoptopenjdk/test/modularity/junit/TestImpliedReadability(module com.test) can not access class org/hamcrest/CoreMatchers(module hamcrest.core) because module module com.test does not read module module hamcrest.core

It is the duplication of the word module (as in module module hamcrest.core) which causes the test to fail,

I notice the openj9 message also includes slashes rather than dots in the referenced class name.

See adoptium/aqa-systemtest#200 for more details.

@pshipton
Copy link
Member

@tajila fyi

@tajila tajila self-assigned this Mar 30, 2021
tajila added a commit to tajila/openj9 that referenced this issue Apr 6, 2021
Currently we output messages with "because module module com.test does
not read module module hamcrest.core". We insert the pre-pending
"module" when printing out module names in `getModuleNameUTF`.

Fixes eclipse-openj9#12315

Signed-off-by: Tobi Ajila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants