Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OffHeap storing dataAddrPtr in temps #7560

Open
rmnattas opened this issue Nov 27, 2024 · 0 comments
Open

Enable OffHeap storing dataAddrPtr in temps #7560

rmnattas opened this issue Nov 27, 2024 · 0 comments

Comments

@rmnattas
Copy link
Contributor

rmnattas commented Nov 27, 2024

Storing dataAddr pointers as internal pointers in temp vars is disabled or not yet coded in multiple areas as further work is needed. This issue explain and lists what's needed for it to be enabled.

One known issue with enabling it is intrinsic CAS calls, where a child has the destination object and another has the offset. For OffHeap the destination object is the aloadi <contiguousArrayDataAddrField> of the destination array, or a temp/aRegLoad of the dataAddrPtr, but that child is also used for card-marking address calculation which needs the base object value. If The child is aloadi <contiguousArrayDataAddrField> then we can access the base object as its child, if its a temp/aRegLoad then its more complex to get the value of the base object.

#7562
#7368 (comment)

@rmnattas rmnattas changed the title Enable OffHeap storing dataAddrPtr in temps. Enable OffHeap storing dataAddrPtr in temps Nov 27, 2024
rmnattas added a commit to rmnattas/omr that referenced this issue Dec 6, 2024
Given issues when storing dataAddrPtr in temps and the dual purpose of
using that as the destination address (correct) and destination object
(incorrect) from some evaluators, the store of dataAddrPtr in temps
is disabled until its fixed (Issue: OMR eclipse-omr#7560)

Signed-off-by: Abdulrahman Alattas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant