Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never return path to pom.xml for artifact files except for type = "pom" #1730

Open
kwin opened this issue Apr 4, 2024 · 0 comments · May be fixed by #1731
Open

Never return path to pom.xml for artifact files except for type = "pom" #1730

kwin opened this issue Apr 4, 2024 · 0 comments · May be fixed by #1731

Comments

@kwin
Copy link
Member

kwin commented Apr 4, 2024 •
edited
Loading

Currently the logic in

m2e-core/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/project/registry/EclipseWorkspaceArtifactRepository.java

Lines 84 to 102 in 5f94521

if(!POM_EXTENSION.equals(extension)) {
MavenProjectFacade facade = context.state.getProjectFacade(pom);
IWorkspaceClassifierResolver resolver = MavenPlugin.getWorkspaceClassifierResolverManager().getResolver();
IPath location = resolver.resolveClassifier(facade, classifier);
if(location == null) {
location = facade.getOutputLocation();
}
if(location != null) {
IResource res = root.findMember(location);
if(res != null) {
file = res.getLocation();
}
}
}
return file.toFile();
may return the pom.xml path. This is used in

m2e-core/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/project/registry/EclipseWorkspaceArtifactRepository.java

Line 145 in 5f94521

public org.apache.maven.artifact.Artifact find(org.apache.maven.artifact.Artifact artifact) {
(an implementation of the Maven SPI org.apache.maven.artifact.repository.ArtifactRepository) to set the artifact's file.

Although returning the path to the pom.xml makes sense for type being pom it doesn't for any other type. In that case one should rather fall back to null.
kwin added a commit that referenced this issue Apr 4, 2024
@kwin
Only ever return pom path for type=pom
0d1f99d 
This closes #1730
@kwin kwin linked a pull request Apr 4, 2024 that will close this issue
Draft
kwin added a commit that referenced this issue Apr 4, 2024
@kwin
Only ever return pom path for type=pom
ea9a37e 
This closes #1730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only ever return pom path for type=pom eclipse-m2e/m2e-core
1 participant
@kwin