Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error range and provide quickfix for invalid dependency structure #487

Open
angelozerr opened this issue Aug 3, 2023 · 2 comments
Labels
enhancement New feature or request validation

Comments

@angelozerr
Copy link
Contributor

Given this dependency (by assuming that the dependency is already downloaded), I hav eno error:

<dependency>
    <groupId>io.quarkiverse.web-bundler</groupId>
    <artifactId>quarkus-web-bundler</artifactId>
    <version>1.0.0-CR2</version>
</dependency>

If I remove groupid

<dependency>
    <artifactId>quarkus-web-bundler</artifactId>
    <version>1.0.0-CR2</version>
</dependency>

I have this error:

image

since we support now dependency validation. But the error range is not correct, it should higlight the dependency tag element.

To know that we could use the error message dependencies.dependency.groupId to higlight the dependency tag element instead just one character after >.

It should be nice to provide a code action which generate the groupid tag element.

There are the same problem when you remove artifactid or version.

@angelozerr angelozerr added enhancement New feature or request validation labels Aug 3, 2023
@vrubezhny
Copy link
Contributor

@angelozerr Isn't this fixed with #479 ?

@angelozerr
Copy link
Contributor Author

No it is a new usecase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validation
Projects
None yet
Development

No branches or pull requests

2 participants