Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test class JUnit5TestFinderJupiterTest #968

Closed
wants to merge 1 commit into from
Closed

Add test class JUnit5TestFinderJupiterTest #968

wants to merge 1 commit into from

Conversation

fedejeanne
Copy link
Contributor

What it does

Adds the test class JUnit5TestFinderJupiterTest. The class contains some tests that cover the current capabilities of JUnit5TestFinder and it was missing from the tests. This class does NOT resemble the other 2 existing classes: JUnit3TestFinder and JUnit4TestFinder.

How to test

Run the tests in the added class.

Author checklist

@fedejeanne fedejeanne mentioned this pull request Dec 4, 2023
Merged
3 tasks
@iloveeclipse
Copy link
Member

Please update your branch from master no merge, rebase.

@fedejeanne fedejeanne force-pushed the add_JUnit5TestFinderJupiterTest branch from 8114bb3 to 4ac1978 Compare December 4, 2023 14:39
@fedejeanne
Copy link
Contributor Author

Please update your branch from master no merge, rebase.

Done

@iloveeclipse
Copy link
Member

I assume this class has to be added to the testsuite. Please check that & add to one.

@fedejeanne fedejeanne force-pushed the add_JUnit5TestFinderJupiterTest branch from 4ac1978 to dd195c1 Compare December 5, 2023 09:03
@fedejeanne
Copy link
Contributor Author

I assume this class has to be added to the testsuite. Please check that & add to one.

Good point, I forgot about that. I added it to JUnitJUnitTests,

@fedejeanne fedejeanne force-pushed the add_JUnit5TestFinderJupiterTest branch from dd195c1 to 4d7f291 Compare December 5, 2023 10:42
@iloveeclipse
Copy link
Member

OK, looks better now, I see 15 new tests added:
https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/PR-968/4/testReport/AutomatedSuite%20org.eclipse.jdt.junit.tests.JUnitJUnitTests%20org.eclipse.jdt.junit.tests/JUnit5TestFinderJupiterTest/

@fedejeanne
Copy link
Contributor Author

@iloveeclipse if this one is OK maybe you could merge it and unlock #953 ?

@iloveeclipse
Copy link
Member

@iloveeclipse if this one is OK maybe you could merge it and unlock #953 ?

I don't get why do you have two PR's with same commits?

@fedejeanne
Copy link
Contributor Author

@iloveeclipse if this one is OK maybe you could merge it and unlock #953 ?

I don't get why do you have two PR's with same commits?

#953 is based on this one: it needs JUnit5TestFinderJupiterTest in order to add 1 test to it. If we merge that one then this PR is also "merged" but if we don't then I still think this one should be merged because the tests provided here were not being done before and they are important.

@fedejeanne
Add test class JUnit5TestFinderJupiterTest
fb32f66 
The class contains some tests that cover the current capabilities of
JUnit5TestFinder and it was missing from the tests.
This class does NOT resemble the other 2 existing classes:
JUnit3TestFinder and JUnit4TestFinder
@fedejeanne fedejeanne force-pushed the add_JUnit5TestFinderJupiterTest branch from 4d7f291 to fb32f66 Compare December 7, 2023 10:16
@iloveeclipse
Copy link
Member

With #953 merged, can we close this PR as duplicate?

@fedejeanne
Copy link
Contributor Author

With #953 merged, can we close this PR as duplicate?

Yes

@fedejeanne fedejeanne closed this Dec 11, 2023
@fedejeanne fedejeanne deleted the add_JUnit5TestFinderJupiterTest branch December 11, 2023 19:42
@noopur2507 noopur2507 mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedejeanne @iloveeclipse @akurtakov