Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ComparingOnCriteriaCleanUp to handle wildcard types #925

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix ComparingOnCriteriaCleanUp to handle wildcard types #925

merged 1 commit into from
Dec 6, 2023

Conversation

jjohnstn
Copy link
Contributor

What it does

Fixes exception caused when using Comparator cleanup with wildcard type.

How to test

See issue or new test.

Author checklist

@jjohnstn jjohnstn self-assigned this Nov 15, 2023
@jjohnstn jjohnstn added the bug Something isn't working label Nov 15, 2023
@jjohnstn
Copy link
Contributor Author

/rebase

@jjohnstn jjohnstn added this to the 4.31 M1 milestone Dec 5, 2023
@jjohnstn
Copy link
Contributor Author

jjohnstn commented Dec 5, 2023

/rebase

@jjohnstn
Fix ComparingOnCriteriaCleanUp to handle wildcard types
64a13c2 
- fixes eclipse-jdt#174
- add logic to buildField to handle wildcard types
- add new scenario to current test in CleanUpTest1d8
@jjohnstn jjohnstn merged commit 3703afa into eclipse-jdt:master Dec 6, 2023
9 checks passed
@jjohnstn jjohnstn deleted the comparator branch December 6, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jjohnstn jjohnstn

Labels
bug Something isn't working
Projects
None yet
Milestone
4.31 M1
Development

Successfully merging this pull request may close these issues.

ComparingOnCriteriaCleanUp ("Use Comparator.comparing()") fails with error
1 participant
@jjohnstn