Enum support for if else to switch cleanup #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jjohnstn, can you have a look? The build error might be unrelated, not sure. |
jjohnstn
requested changes
Jul 18, 2024
....jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchFixCore.java
Outdated
Show resolved
Hide resolved
....jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchFixCore.java
Outdated
Show resolved
Hide resolved
....jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchFixCore.java
Outdated
Show resolved
Hide resolved
....jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchFixCore.java
Outdated
Show resolved
Hide resolved
jjohnstn
approved these changes
Jul 18, 2024
|
Thanks @carstenartur |
jjohnstn
added a commit
to jjohnstn/www.eclipse.org-eclipse
that referenced
this pull request
Jul 31, 2024
vogella
pushed a commit
to eclipse-platform/www.eclipse.org-eclipse
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds support for enum to the cleanup in charge for refactoring chains of "if else" to switch.
How to test
Run the cleanup on code with if else chains or add junit test cases.
Author checklist