Fix buggy Javadoc styling enhancements menu +hard to read colored type parameters (#1442) #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedeemerSK
commented
Jul 1, 2024
...pse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/MenuVisibilityMenuItemsConfigurer.java
Show resolved
Hide resolved
- incorrect text was searched for inside HTML content to see if enhancements are present - menu actions for enhancements enabled state were not set / left only when enhancements were present in content Fixes eclipse-jdt#1442
Re-create them every time they're being requested. Fixes eclipse-jdt#1442
|
I've just rebased on master to run tests / checks on latest head before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes buggy styling enhancements menu (see #1442 (comment)):
Also makes Javadoc to render (generic) type parameters with same font-weight (was lighter) like the rest of the method signature - see #1442 (comment)
How to test
Toggle / change all styling enhancements settings via styling enhancements menu on JavadocHover's and JavadocView's tollbar and confirm styling enhancements menu reflect current settings + javadoc content being displayed and available actions have expected results (eg. toggling / changing / resetting colors).
Scenarios of using styling enhancements menu to consider:
Author checklist