DRAFT: Make AST map pre 1.8 versions to 1.8

[akurtakov]

As the compiler mandates 1.8 already it makes sense for the AST to do the same.

[akurtakov]

@iloveeclipse What do you think?

[iloveeclipse]

@iloveeclipse What do you think?

Jenkins is not accessible, how many test fails are there? I'm not AST expert, I can only remember I've tried to use latest AST in JDT debug and that failed with tons of errors...

[akurtakov]

Jenkins issue is https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5498 . My question is more about the goal not that much about the work involved ( I know it will require quite some).
Btw, can you point me what you have tried in jdt.debug so I can use/test it with this one?

[iloveeclipse]

My question is more about the goal not that much about the work involved ( I know it will require quite some).

I assume working with "old" level AST for Java version we don't support anymore should be more of academic interest? I don't know if consumers like Xtext use AST at some minimal JLS level internally and expect us to keep it going forever. @szarnekow ?

Btw, can you point me what you have tried in jdt.debug so I can use/test it with this one?

I see I've finally managed to fix it: eclipse-jdt/eclipse.jdt.debug#109, so that should be fine.

[akurtakov]

@iloveeclipse FYI, there are no test failures, presumably because the maps changes make tests run with 1.8 level which all the tests are supposedly succeeding with.

[iloveeclipse]

Cool.

[akurtakov]

May I assume that if @szarnekow (or someone else ) doesn't raise serious concern this approach if fine to proceed with?

[iloveeclipse]

@mpalat, @srikanth-sankaran, @jarthana , @noopur2507 : any objections?

[iloveeclipse]

@akurtakov : looking at the code, you only touched the mapping. But the AST constructor still uses JLS4_INTERNAL , JLS2_INTERNAL etc and only has the check below:

if (level < JLS2_INTERNAL && level > JLS_Latest) {
   throw new IllegalArgumentException("Unsupported JLS level : " + level); //$NON-NLS-1$
}

Do you plan to update this as well?

[akurtakov]

Yes, I do. Also cleaning the tests to not run old compliance e.g jls2 compliance (

eclipse.jdt.core/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ConverterTestSetup.java

Line 621 in 0c3986b

return runJLS3Conversion(unit, resolveBindings, checkJLS2, false);

leading to

eclipse.jdt.core/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ConverterTestSetup.java

Line 628 in 0c3986b

if (checkJLS2) {

) which significantly complicates, slows down and prevent the suite to be useful to verify "supported" JDT features are implemented proper (a good number of ast failures in https://ci.eclipse.org/ls/job/jdt-core-incubator/job/dom-with-javac/lastSuccessfulBuild/testReport/ ).