StackOverflowException in XLargeTest#test011()

[jarthana]

To reproduce this, you need to select the single given test name (by setting TESTS_NAMES at the top).

The SOE happens at BinaryExpression#containsPatternVariable(). The reason it happens is, this method and possibly few others that were added to BinaryExpression were not overridden in CombinedBinaryExpression and therefore fell into the SOE. Just as analyseCode(), we should have for the other methods too that propagate to left and right.

Another note is, perhaps we should limit the call containsPatternVariable() only for compliance >= 16.

[srikanth-sankaran]

To reproduce this, you need to select the single given test name (by setting TESTS_NAMES at the top).

The SOE happens at BinaryExpression#containsPatternVariable(). The reason it happens is, this method and possibly few others that were added to BinaryExpression were not overridden in CombinedBinaryExpression and therefore fell into the SOE. Just as analyseCode(), we should have for the other methods too that propagate to left and right.

Another note is, perhaps we should limit the call containsPatternVariable() only for compliance >= 16.

So curious: why would this show up only when you run a single test ??

[jarthana]

Not sure, but I suspect it could be a timing issue. I also see tests failing when I run them in debug mode and not otherwise.

[srikanth-sankaran]

This problem goes away with #2011 - Much water has flown under the bridge. org.eclipse.jdt.internal.compiler.ast.Statement.containsPatternVariable() is a single visitor based method that answers the question without hierarchy members having to override it.