-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Bazel alias //:iceoryx
#2368
Comments
@lalten sorry, but can we please revert this change. It does not make sense to have the C bindings as In your linked example, why not just use |
tbh the main reason was to not have to patch how rules_ros2 uses iceoryx when substituting Bzlmod Iceoryx for its rules_foreign_cc version. |
Just for the sake of understanding. What do you mean with patching We are currently working on |
rules_ros2 is using
The idea in this ticket was to make any dependencies that already depend on "@iceoryx" continue to work in the exactly same way with Iceoryx's native Bazel build. |
Okay, but the current bazel setup should already provide all of this libraries. I don't understand why |
Brief feature description
To enable compatibility with rules_ros2 and other Bazel-built Iceoryx consumers, it would be good to have an
:iceoryx
alias so that e.g. https://github.com/mvukov/rules_ros2/blob/90e7e2d72e1dda8e76ae7ecb7d6e39fef6929270/repositories/cyclonedds.BUILD.bazel#L194 works (if you add the dependency like below)Detailed information
No cons, having the main target have the name of the main package is Bazel convention.
The text was updated successfully, but these errors were encountered: