-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iceoryx support fast-dds #2199
Comments
Hi @shenkai9999 Thanks for opening this issue. You are right currently only a gateway using Cyclone DDS is available. There were some activities to add a gateway using FastDDS a couple of years ago but it never got merged, see here: #444 Would you have time to contribute a gateway using FastDDS? If so I would suggest creating a separate repository for it like we did for the Cyclone DDS one. Ping me if I shall create that repository for you. |
Hi @mossmaurice. I currently have time to contribute a Fast DDS gateway. Should I submit it to the repository: iceoryx-gateway-dds? Is there a specific version requirement for Fast DDS? |
Hi @SchwarzeMagie Great to hear! :) The iceoryx Cyclone DDS Gateway is still based on an older commit. I think adding it to the same repository makes sense. However, you might need to rename and restructure things in there a bit so that the user can choose which DDS implementation to use.
No, not from my side. Let me know if you need any help. We can use the chat to discuss any issues: https://gitter.im/eclipse/iceoryx |
Hello @SchwarzeMagie ,do you have any plans to integrate fast-dds-gateway into iceoryx? |
Hi @shenkai9999, I plan to make my first code commit this weekend. I still have some details that need to be clarified. |
Hello @SchwarzeMagie ,have you integrate fast-dds-gateway into iceoryx?I think I'll be fortunate to take a look at your code. |
Hi @shenkai9999, I'm sorry for the delay in submission due to a sudden change in my work. I have now submitted a merge request with my implemented code to the iceoryx-gateway-dds repository. Please feel free to review it. |
Hi @mossmaurice, My FastDDS gateway code in the iceoryx-gateway-dds repository has been approved for merging. Could I also submit the FastDDS gateway code to the release_2.0 branch of iceoryx? Because 2.0.x is the version I primarily use now. |
@SchwarzeMagie the 2.0.x branch receives only bugfixes. We want to have a 3.0 release soonish, though |
Alright, I understand. Is this issue considered resolved? |
@SchwarzeMagie yes, this can be considered resolved then. |
@SchwarzeMagie Thanks for your contribution and sorry for my late reply! We plan to release iceoryx1 v3.0 soon-ish. The only major issue left is #1295 see here. I think we'll discuss the details in the next iceoryx developer meetup on Tuesday 5th November 2024 17:00 CET. Feel free to join. Once I hope to use the |
Hi @mossmaurice ,Thank you very much for your meeting invitation. However, due to the time difference, I might already be resting at that time, and I apologize for that. I would be happy to make modifications and submit them regarding the gateway adaptation requirements after the release of iceoryx 3.0. Thank you. |
Currently, iceoryx already supports cyclone dds for device to device communication through the gateway. When can fast dds be supported?Because fast dds are also being used by many people,this support is very meaningful!
The text was updated successfully, but these errors were encountered: