Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates source file #11

Closed
wants to merge 1 commit into from
Closed

Updates source file #11

wants to merge 1 commit into from

Conversation

EgorWeders
Copy link
Contributor

@EgorWeders EgorWeders commented Dec 12, 2024 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Code is formatted with clang-format
  2. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  3. Relevant issues are linked
  4. Add sensible notes for the reviewer
  5. All checks have passed
  6. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido
Copy link
Member

@EgorWeders the template needs to be ported to the latest iceoryx main. There is #6 for this but it's stalled. Closing this for now an continue the discussion on #6

@elBoberido elBoberido closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to update example in template
2 participants
@EgorWeders @elBoberido