[Ubuntu] "Always Trust Everything Confirmation" window is hidden

[iuliavasii]

Environment:

• Ubuntu 20.04
• gtk 3.24.20
• Eclipse 2023.12

Steps to reproduce:

• try to install any signed/unsigned packages using "Install New Software"
• the wizard will take you to "Do you trust content" window (attached), added here: https://eclipse.dev/eclipse/news/4.28/platform.php#trusted-authorities
• click on "Always trust all authorities" / "Always trust all content"

Note that "Always Trust Everything Confirmation" window (attached) pops-up in the back of the current window, user is not able to click on it and the product becomes unusable.

Notes:

• Using "Select All" instead of "Always trust all authorities" / "Always trust all content" doesn't show any pop-up and therefore the installation finishes successfully.
• I was able to reproduce it in Eclipse 2024-12 as well.
  
  

[merks]

This sounds similar to

eclipse-oomph/oomph#116

Actually it's not just similar it's basically describing the same problem...

Maybe it's a bug in SWT shell parenting behavior because nothing has changed around this code for quite a few years...

We are explicitly passing in the shell of the dialog on which the checkbox is located:

p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustAuthorityDialog.java

Lines 663 to 675 in 65348d6

	trustAlwaysButton.addSelectionListener(widgetSelectedAdapter(e -> {
	if (trustAlwaysButton.getSelection()) {
	// Prompt the user to ensure they really understand what they've chosen, the
	// risk, and where the preference is stored if they wish to change it in the
	// future. Also ensure that the default button is no so that they must
	// explicitly click the yes button, not just hit enter.
	var messageDialog = new MessageDialog(getShell(),
	ProvUIMessages.TrustAuthorityDialog_TrustAllAuthoritiesConfirmationTitle, null,
	ProvUIMessages.TrustAuthorityDialog_TrustAllAuthoritiesConfirmationDescription,
	MessageDialog.QUESTION,
	new String[] { ProvUIMessages.TrustAuthorityDialog_AcceptTrustAllAuthorities,
	ProvUIMessages.TrustAuthorityDialog_RejectTrustAllAuthorities },
	1) {

So the parent shell should be the correct one.

[akurtakov]

Both Ubuntu and Eclipse versions are way too old. Would you please try whether this happens with latest Ubuntu LTS and Eclipse 2024-09?

[iuliavasii]

I've tried these combinations:

• Eclipse 2024-09 on Ubuntu 20.04 -> is reproducible
• Ubuntu 22.04 -> not reproducible (I used Eclipse 2023-12, but I believe the Eclipse version doesn't matter here)