WorkspaceCommandStack.isSaveNeeded() does not consider AbstractCommand.NonDirtying

[pcdavid]

• 🆔 Bugzilla ID: #551164
• 📘 Project: Modeling / EMF Services / Transaction
• 🗓 Created: 2019-09-17T12:25:16Z
• ❓ Status: NEW /

[pcdavid]

Comment #0 on Tue Sep 17 2019 14:25:16 GMT+0200 (Central European Summer Time):

According to Ed's proposal in https://www.eclipse.org/forums/index.php/m/1814570/#msg_1814570 I file this bug.


We are using TransactionalEditingDomain with a WorkspaceCommandStack.
org.eclipse.emf.edit.ui.action.CopyAction (or the used CopyCommand) makes the editor dirty.

In the editor a CommandStackListener is registered. When an event is raised, it tells the editor to check it's dirty property. The editor then calls WorkspaceCommandStack.isSaveNeeded(). Which always returns true, even for a copy command which does not change the editor's content.
In comparison the BasicCommandStack.isSaveNeeded() method asks the command whether it has changed the model.

---

Comment #1 on Tue Sep 17 2019 16:45:08 GMT+0200 (Central European Summer Time):

Marcus,

This isn't the most active project so if you really need a fix, you might consider contributing one or sponsoring someone.

---

Comment #2 on Sat May 14 2022 15:51:35 GMT+0200 (Central European Summer Time):

Eclipse EMF Transaction is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/emf-transaction.

If this issue is relevant to you and still present in the latest release:

* Create a new issue at https://github.com/eclipse/emf-transaction/issues/.
  * Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  * In the GitHub description, start with a link to this bugzilla ticket
  * Optionally add new content to the description if it can helps towards resolution
* Update bugzilla ticket
  * Add to "See also" property (up right column) the link to the newly created GitHub issue
  * Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  * Set status as CLOSED MOVED

All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for EMF Transaction will be archived and made read-only.