Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionalAdapterFactoryContentProvider could expose domain for subclasses #12

Open
pcdavid opened this issue Sep 4, 2022 · 1 comment
Labels
bugzilla Issues migrated from the old Eclipse Bugzilla

Comments

@pcdavid
Copy link
Contributor

pcdavid commented Sep 4, 2022

  • πŸ†” Bugzilla ID: #308171
  • πŸ“˜ Project: Modeling / EMF Services / Transaction
  • πŸ—“ Created: 2010-04-06T09:57:06Z
  • ❓ Status: NEW /
@pcdavid pcdavid added the bugzilla Issues migrated from the old Eclipse Bugzilla label Sep 4, 2022
@pcdavid
Copy link
Contributor Author

pcdavid commented Sep 4, 2022

Comment #0 on Tue Apr 06 2010 11:57:06 GMT+0200 (Central European Summer Time):

Build Identifier: 20100218-1602, plugin org.eclipse.emf.transaction.ui_1.3.1.v20090819-1457

Class TransactionalAdapterFactoryContentProvider does not provide any access to field domain.

Subclasses than have to keep their own copy of this object. I think that this arrangement is not necessary. TransactionalAdapterFactoryContentProvider could expose the TransactionalEditingDomain via a new protected method getEditingDomain().

The same applies to TransactionalAdapterFactoryLabelProvider.

Reproducible: Always

Comment #1 on Tue Apr 06 2010 17:47:17 GMT+0200 (Central European Summer Time):

Can you provide a quick patch for the access you require?

Comment #2 on Sat May 14 2022 15:51:28 GMT+0200 (Central European Summer Time):

Eclipse EMF Transaction is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/emf-transaction.

If this issue is relevant to you and still present in the latest release:

* Create a new issue at https://github.com/eclipse/emf-transaction/issues/.
  * Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  * In the GitHub description, start with a link to this bugzilla ticket
  * Optionally add new content to the description if it can helps towards resolution
* Update bugzilla ticket
  * Add to "See also" property (up right column) the link to the newly created GitHub issue
  * Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  * Set status as CLOSED MOVED

All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for EMF Transaction will be archived and made read-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from the old Eclipse Bugzilla
Projects
None yet
Development

No branches or pull requests

1 participant