A proposal for improving the WorkspaceSynchronizer

[pcdavid]

• 🆔 Bugzilla ID: #285263
• 📘 Project: Modeling / EMF Services / Transaction
• 🗓 Created: 2009-07-31T11:29:34Z
• ❓ Status: NEW /

[pcdavid]

Comment #0 on Fri Jul 31 2009 13:29:34 GMT+0200 (Central European Summer Time):

When deleting a resource from workspace, the workspace synchronizer will fire handleResourceChanged events events on all resources though they havent been changed.

This is because in the workspace synchronizer in the processDelta operation in the IResourceDelta.CHANGED case does not check if the contents actually have been changed.

I find this a bit myself esoteric but it seems thats the eay how resource change events work with eclipse: When a resource is deleted the ResourcePlugin puts the entire workspace into the resource delta one is required to visit in order to figure out in what the actual change consists in.

To check if a resource has actualy changed on has the check

if ((delta.getFlags() & IResourceDelta.CONTENT) != 0) [1]

This would avoid a lot of unload and reload operations, especialy when it comes to GMF after a diagram is deleted and this events ripples through all editing domains with their attached resource sets causing the lag



[1] http://www.eclipse.org/articles/Article-Resource-deltas/resource-deltas.html

---

Comment #1 on Sat May 14 2022 15:51:44 GMT+0200 (Central European Summer Time):

Eclipse EMF Transaction is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/emf-transaction.

If this issue is relevant to you and still present in the latest release:

* Create a new issue at https://github.com/eclipse/emf-transaction/issues/.
  * Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  * In the GitHub description, start with a link to this bugzilla ticket
  * Optionally add new content to the description if it can helps towards resolution
* Update bugzilla ticket
  * Add to "See also" property (up right column) the link to the newly created GitHub issue
  * Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  * Set status as CLOSED MOVED

All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for EMF Transaction will be archived and made read-only.