spath.tld is not included in the final jar

[volosied]

I see that in the previous JSTL 1.2 Implementation jars that spath.tld is included. However, I don't see it included in under in the org.glassfish.web:jakarta.servlet.jsp.jstl:version=2.0.0 jar?

However, the spath.tld is in tracked in github? https://github.com/eclipse-ee4j/jstl-api/blob/master/impl/src/main/java/org/apache/taglibs/standard/extra/spath/spath.tld

Can anyone clarify this? Thanks!

[volosied]

Correction: wasn't included in the 1.2 binaries. But it's still not clear why the file exists if it's not needed in the binary?

Since there's not much activity here, I'll follow on the mailing list for clarification on this specific TLD.

[volosied]

This is an example TLD, so I can see why it's not included in the binary. The package it's contained within all relates to this spath filter.

I found limited examples which use this tag. One example is below. The parse tag accepts a filter, and the implementation provides this spath one. Looks like one should to use the select and the var attributes per the class methods and this example TLD.

https://github.com/eclipse-ee4j/jstl-api/blob/master/impl/src/main/java/org/apache/taglibs/standard/extra/spath/SPathTag.java#L84-L90

<ex:SPath var="spath" select="//a"/>
<x:parse var="a" filter="${spath}">
 <nope>
  <a>
   <b>
    <c>
     foo
    </c>
   </b>
   <d>
     bar
   </d>
  </a>
 </nope>
</x:parse>

<x:out select="$a//c"/>
<x:out select="$a/a/d"/>

I have a few ideas moving forward.

1. Keep things as is (excluded from binary and included with source)
2. Delete it, and document in here in this issue?
3. Move to the resources folder
4. Delete the file, but make it's contents as a comment in the SPathTag class.
5. Add this example to an package.html file? (Based off: https://github.com/eclipse-ee4j/jstl-api/blob/master/api/src/main/java/jakarta/servlet/jsp/jstl/tlv/package.html)
6. Mention the example spec?

I'm not really leaning one way or another as this seems like a minor file. @pnicolucci do you have any suggestions / recommendations?

[volosied]

I don't see any issue with this as is for EE10. We can work on this in at a later date.