Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set the servlet registration in the TLDScanner instead of the constant "jsp" #25

Open
Thihup opened this issue Dec 23, 2020 · 2 comments

Comments

@Thihup
Copy link

Thihup commented Dec 23, 2020

In the TLDScanner, it searches for the "jsp" servlet registration.

ServletRegistration reg = ctxt.getServletRegistration("jsp");

While it's not wrong, it would be better if it was possible to change the servlet it searches for.

https://github.com/eclipse-ee4j/wasp/blob/master/src/main/java/org/apache/jasper/runtime/TldScanner.java#L164

@arjantijms
Copy link
Contributor

+1 I encountered that too.

@joakime
Copy link
Member

joakime commented Dec 24, 2020

That line of code only looks for registration to get the "validating" init-param value.
Perhaps a context attribute to override that would be a better choice than messing with the spec assigned servlet names. (which we have to change anyway because we can't reference the three letters "jsp" anymore in a future update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants