Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQ-JMSRA pooled connection validation broken: ManagedConnectionFactory does not implement ValidatingManagedConnectionFactory #422

Open
svendiedrichsen opened this issue Oct 1, 2018 · 0 comments

Comments

@svendiedrichsen
Copy link

The class com.sun.messaging.jms.ra.ManagedConnectionFactory does not implement the interface javax.resource.spi.ValidatingManagedConnectionFactory. This prevents Application-Servers like i.e. Glassfish/Payara 4/5 to validate pooled JMS connections and has a variety of negative effects in case of broken connections.

// code excerpt from com.sun.enterprise.resource.allocator.AbstractConnectorAllocator
... 
public Set getInvalidConnections(Set connectionSet)
            throws ResourceException {
        if (mcf instanceof ValidatingManagedConnectionFactory) {
            return ((ValidatingManagedConnectionFactory) this.mcf).
                    getInvalidConnections(connectionSet);
        }
        return null;
    }
...
@svendiedrichsen svendiedrichsen changed the title MQ-JMSRA Connection pooling broken: ManagedConnectionFactory does not implement ValidatingManagedConnectionFactory MQ-JMSRA pooled connection validation broken: ManagedConnectionFactory does not implement ValidatingManagedConnectionFactory Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant