In order to maintain a coherent code style throughout the project we ask every contributor to adhere to a few simple
style guidelines. We assume most developers will use at least something like vim and therefore have support for
automatic code formatting, we are not going to list the guidelines here.
Checkstyle is a tool that can statically analyze your source code to check against a set of given rules. Those rules are formulated in an XML document (you can find it in every code repository in the EDC organization). Many modern IDEs have a plugin available for download that runs in the background and does code analysis.
Our checkstyle config is based off of the Google Style with a few additional rules such as the naming of constants and Types.
Note: currently we do not enforce the generation of Javadoc comments, even though documenting code is highly recommended. We might enable this in the future, such that at least interfaces and public methods are commented.
Checkstyle can be run in different ways: implicitly we run it through the checkstyle Gradle Plugin
during gradle build. That will cause the build to fail if any violations are found. But in order to get better
usability and on-the-fly reporting, Checkstyle is also available as IDE plugins for many modern IDEs, and it can run
either on-demand or continuously in the background:
Apart from running Checkstyle locally as IDE plugin, we do run it on our GitHub Actions pipeline. At this time, Checkstyle will only spew out warnings, but we may tighten the rules at a future time and without notice. This will result in failing GitHub Action pipelines. Also, committers might reject PRs due to Checkstyle warnings.
It is therefore highly recommended running Checkstyle locally as well.
If you do not wish to run Checkstyle on you local machine, that's fine, but be prepared to get your PRs rejected simply because of a stupid naming or formatting error.
Note: we do not use the Checkstyle Gradle Plugin on GitHub Actions because violations would cause builds to fail. For now, we only want to log warnings.
If you are using Jetbrains IntelliJ IDEA, we have created a specific code style configuration that will automatically format your source code according to that style guide. This should eliminate most of the potential Checkstyle violations right from the get-go. You will need to reformat your code manually or in a pre-commit hook though.
If you absolutely want to make sure that no piece of ever-so-slightly malformed code even hits your hard disk, we
advise you to use the SaveActions plugin for IntelliJ IDEA. It
takes care that your code is always correctly formatted. Unfortunately SaveActions has no export feature, so please just
copy this configuration:
For most other editors and IDEs we've supplied an .editorConfig file for every repository that can be
placed at the appropriate location. The specific location will largely depend on your editor and your OS, please refer
to the official documentation for details.