Wrong image on pattern application wizard

[eclipse-diffmerge-bot]

Images of pattern on the "Apply pattern" wizard can be wrong when switching between patterns (e.g. using the Pattern combo box).

A systematic use-case can be obtained in debug mode by simulating a long thread that calculates and update a pattern image on the wizard while the pattern itself is not selected anymore. More specifically, at the beginning of the method org.eclipse.emf.diffmerge.patterns.ui.misc.AbstractPatternImageBuilderJob.run(IProgressMonitor) add an if condition as follows: if (the current pattern is pattern X) then make the thread sleep for 5s. With this modification, from the runtime application, do the following steps:

1. Open the "Apply pattern" wizard
2. Choose the pattern X
3. Switch to another pattern (for example pattern Y) quickly (within 5s)
   => The image of pattern Y is displayed at first and then replaced by the image of pattern X even though the chosen pattern is pattern Y

🆔 ECLIPSE-511634 👷 minh.tu.ton.that 📅 2017-02-03 🔎 0.7.0

[eclipse-diffmerge-bot]

olivier.constant commented on 2017-09-12

Confirmed.