API: Pass EStructuralFeature.Setting as arguments to IDiffPolicy.considerEqual

[eclipse-diffmerge-bot]

Hi Olivier,

we would like to implement IDiffPolicy.considerEqual in a way that depends not only on the Feature and the two values itself, but also on the object that holds the value.

Our concrete example is that all our elements have a name, but we don't care about the name for objects of a certain type in a comparison.

I would thus need an enhanced API which passes the objects holding the values in question as an additional parameter:

boolean considerEqual(Object value1_p, Object value2_p, EAttribute attribute_p);

would become:

boolean considerEqual(Setting s1, Setting s2), with a guarantee that s1.feature == s2.feature

Get well soon!
Felix

🆔 ECLIPSE-420003 👷 felix.dorner 📅 2013-10-21

[eclipse-diffmerge-bot]

olivier.constant commented on 2013-12-11

OK, makes sense. I originally didn't think there was a need for that much flexibility but you proved me wrong.