Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EMF Compare-like option to "merge all non-conflicting changes" #129

Open
eclipse-diffmerge-bot opened this issue Jul 22, 2021 · 1 comment
Labels
enhancement New feature or request ui

Comments

@eclipse-diffmerge-bot
Copy link

The Diff/merge dialog offers no way to quickly merge all non-conflicting changes. I think it could be a good addition.

=> It could be partially done using category filters, but due to ECLIPSE-514781, it is not entirely feasible.

🆔 ECLIPSE-514782 👷 michael.tiller 📅 2017-04-05 🔎 0.7.0

@pdulth pdulth added enhancement New feature or request ui labels Jul 22, 2021
@eclipse-diffmerge-bot
Copy link
Author

olivier.constant commented on 2017-06-06

Since ECLIPSE-514781 is now fixed, it can be done the way you suggest either manually or automatically via an "option" (probably a dedicated button). I am unsure, however, that this is what is needed in the general case.

When merging text, the notion of conflict is rather simple. With models, there are "straightforward" conflicts such as deletion vs. modification, concurrent setting of the same non-many property, etc. (cf. the PhD work by K. Altmanninger). You may, however, also have conflicts that arise after impact analysis of the desired merge operation. I fear that a "merge all non-conflicting" button leads the user to believe that what he/she is doing is safe while it may not be.

It seems to me that we should investigate more on conflict analysis, or provide a temporary solution to your need that makes my above statement clear to the user.

michael.tiller commented on 2017-06-07

Great! For "my" need, the fix of 514781 is enough, so I don't think you should think of providing a temporary solution for this ticket (we already implemented our own temporary solution).
I mainly opened these tickets to open the discussion on how to improve the overall product (because the project I'm working on is quite far from production). I understand what you mean about "hidden" conflicts, and honestly I'm not expert enough in the whole merge/model thing to help you much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
None yet
Development

No branches or pull requests

2 participants