Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IComparisonMethodFactory overriden classes #125

Open
eclipse-diffmerge-bot opened this issue Jul 22, 2021 · 1 comment
Open

IComparisonMethodFactory overriden classes #125

eclipse-diffmerge-bot opened this issue Jul 22, 2021 · 1 comment

Comments

@eclipse-diffmerge-bot
Copy link

In IComparisonMethodFactory:
1/ Rename getOverridenClasses to getOverridenComparisonMethods.
2/ In this method, offer a secondary mean to designate comparison methods with a symbolic key (like id in plugins) instead of a hard class dependency. Add a way to register a comparison method with such a key.

🆔 ECLIPSE-514498 👷 eric.lépicier 📅 2017-03-30 🔎 0.7.0

@eclipse-diffmerge-bot
Copy link
Author

olivier.constant commented on 2017-04-03

About 1/, I agree that the method name could be made clearer. Maybe something like "getOverridenFactories" would be better.
"getOverridenComparisonMethods" refers to a particular case, the case of comparison methods, so it could be an additional method but not the general, inherited one; still, I'm not convinced having an additional method for this specific case would be a good idea.

2/ Agreed that there are obvious use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants