You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In IComparisonMethodFactory:
1/ Rename getOverridenClasses to getOverridenComparisonMethods.
2/ In this method, offer a secondary mean to designate comparison methods with a symbolic key (like id in plugins) instead of a hard class dependency. Add a way to register a comparison method with such a key.
About 1/, I agree that the method name could be made clearer. Maybe something like "getOverridenFactories" would be better.
"getOverridenComparisonMethods" refers to a particular case, the case of comparison methods, so it could be an additional method but not the general, inherited one; still, I'm not convinced having an additional method for this specific case would be a good idea.
In IComparisonMethodFactory:
1/ Rename getOverridenClasses to getOverridenComparisonMethods.
2/ In this method, offer a secondary mean to designate comparison methods with a symbolic key (like id in plugins) instead of a hard class dependency. Add a way to register a comparison method with such a key.
🆔 ECLIPSE-514498
👷 eric.lépicier
📅 2017-03-30
🔎 0.7.0
The text was updated successfully, but these errors were encountered: