Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position attribute possibly wrong (0-indexed) for remote ingests #1000

Open
blms opened this issue Dec 4, 2023 · 0 comments
Open

Position attribute possibly wrong (0-indexed) for remote ingests #1000

blms opened this issue Dec 4, 2023 · 0 comments
Labels

Comments

@blms
Copy link
Contributor

blms commented Dec 4, 2023

We noticed in a meeting that some position attributes start at 0 for canvases, possibly due to remote ingest issues.

Example on dev with 0 index:
https://dev.readux.io/iiif/v2/2qnsf0jr/manifest

Example on dev with 1 index:
https://dev.readux.io/iiif/v2/1898-Fillm2-EMU/manifest

Note that canvas label is serialized from Canvas.position:

obj.label = str(obj.position)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant