Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serious Lag expanding Niagara river (and others) due to graph #108

Closed
ecc521 opened this issue Jun 28, 2020 · 5 comments
Closed

Serious Lag expanding Niagara river (and others) due to graph #108

ecc521 opened this issue Jun 28, 2020 · 5 comments
Labels
Feature Request Feature Request

Comments

@ecc521
Copy link
Owner

ecc521 commented Jun 28, 2020 •
edited
Loading

The Niagara river (https://rivers.run/#Niagara%20Fort%20Erie) reports data extremely frequently, so graph contains several hundred points. This results in a multi second lag opening the river view once full data has been loaded (the initial load is only a few data points, so works at normal speed. Once full data is loaded, full data is drawn on future openings, resulting in heavy lag)
@ecc521 ecc521 added the Bug Something isn't working correctly label Jun 28, 2020
@ecc521 ecc521 changed the title Serious Lag expanding Niagara river due to graph Serious Lag expanding Niagara river (and others) due to graph Jun 28, 2020
@ecc521 ecc521 changed the title Serious Lag expanding Niagara river (and others) due to graph Serious Lag re-expanding Niagara river (and others) due to graph Jun 28, 2020
@ecc521 ecc521 added the Low-Priority Low impact - Do other things first. label Jun 28, 2020
@ecc521 ecc521 added High-Priority High impact. Work on this before other things. and removed Low-Priority Low impact - Do other things first. labels Jul 10, 2021
@ecc521
Copy link
Owner Author

ecc521 commented Jul 10, 2021

This is now significantly more important with the NWS gauges - offscreen canvas should probably be used

@ecc521 ecc521 changed the title Serious Lag re-expanding Niagara river (and others) due to graph Serious Lag expanding Niagara river (and others) due to graph Jul 10, 2021
@ecc521 ecc521 removed the Bug Something isn't working correctly label Jul 10, 2021
@ecc521
Copy link
Owner Author

ecc521 commented Jul 11, 2021 •
edited
Loading

d1d5a1c massively mitigates this issue, making it far less catastrophic. Backgrounding should be done, but it is now an enhancement, not a critical issue.

@ecc521 ecc521 added Feature Request Feature Request and removed High-Priority High impact. Work on this before other things. labels Jul 11, 2021
@ecc521
Copy link
Owner Author

ecc521 commented Mar 6, 2022

This issue is more serious with additional USGS data as of 0ccaf5e, and impedes the potential addition of more data (like 7 days)

@ecc521 ecc521 closed this as completed Mar 6, 2022
@ecc521
Copy link
Owner Author

ecc521 commented Mar 6, 2022

Accidentally closed - reopening

@ecc521 ecc521 reopened this Mar 6, 2022
@ecc521 ecc521 pinned this issue Mar 6, 2022
@ecc521
Copy link
Owner Author

ecc521 commented Mar 6, 2022

Fixed in a306a02
Absolutely stunning speed boost

@ecc521 ecc521 closed this as completed Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ecc521