Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tenderly sim for end-state of the queue tx in timelock #16

Open
petrovska-petro opened this issue Jan 11, 2024 · 3 comments
Open
Assignees

Comments

@petrovska-petro
Copy link
Collaborator

          the ui is def a great addition, something that came to my mind that will be valuable to support is that when queuing a tx in the timelock to have a better scope of what storage variables may affect or what modifications represents, would be worth to have a tenderly simulation url to share w/ the rest of potential signers? 

wdyt of adding that feature in the flow while either queuing and/or executing so it prints out on the cli?

so early queuing of txs will allow quick inspection of what result will be resulting when finally executing after the delay*

Originally posted by @petrovska-petro in #3 (comment)

@sajanrajdev
Copy link
Collaborator

Great idea. We should add it to the sprint for before launch but with lower prio than other core features as the Safe UI already incorporates simulation.

My only suggestion is to add a Tenderly sim to all transactions (timelocked or not) in the same way that we do in the Badger Multisig repo. No harm and could benefit the review of txs outside of paramter changes.

@petrovska-petro
Copy link
Collaborator Author

the case im suggesting its not the simulation when queuing, which i agree already is supported by the safe ui when its going to be signed

what it is not supported by the safe ui currently afaik, its to provide the simulation of the state of the tx which is queued and going to be exec, what states will be changing in the architecture, that's what i think it's a valuable addition

i.e:

  • provide the sim of the after state of the tx which is just going to be queued, providing awareness of what results will have in the system

not having this the current situation is something like this:

  • i can sim the queue tx and perhaps its correct signatures, targets, deadline, but what im signing now in what will result after the delay?

wdyt?

@sajanrajdev
Copy link
Collaborator

@petrovska-petro, I think it makes sense to show the simulation of the transaction for when it executes indeed. Perhaps it can be an option that gets automatically toggled when the script runs the queuing route but that it can manually disabled in case we want to simulate the queuing itself for whatever reason. For the rest of the operations, let's make sure that we can also simulate (i.e. treasury ops, etc..).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💤 Backlog
Development

No branches or pull requests

2 participants