Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Theming overhaul #20

Closed

Conversation

jameswilson
Copy link

@jameswilson jameswilson commented Aug 28, 2018

This is a ⚠️ work-in-progress PR to start resolving various theming issues, including primarily #16 and also provides a css-based solution to resolve #19 by adding a class for each bibliographical information.

Here is a copy of the task list from #16 to show progress...

  • Separate business logic from display logic in template_preprocess_ebsco_result templates and move as much as possible to ebsco-result.html.twig that can be overridden by a theme.
  • Convert auto_link to a Twig filter.
  • Separate business logic from display logic in template_preprocess_ebsco_results and move as much as possible to ebsco-results.html.twig that can be overridden by a theme.
  • Ensure preprocess code changes follow Drupal 8 PHP syntax coding standards.
  • Ensure all Twig templates follow Drupal 8 Twig syntax coding standards.

@jameswilson jameswilson force-pushed the feature/theming-overhaul branch 2 times, most recently from ae3f4b4 to 8702732 Compare August 28, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide certain Bibliographic Details from detail record display
2 participants