Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass PHP Code Sniffer Drupal standard #18

Open
jameswilson opened this issue Aug 13, 2018 · 0 comments
Open

Pass PHP Code Sniffer Drupal standard #18

jameswilson opened this issue Aug 13, 2018 · 0 comments

Comments

@jameswilson
Copy link

jameswilson commented Aug 13, 2018

3598 errors, 133 warnings were found when testing this module against the PHP Code Sniffer Drupal standard.

$ phpcs --report=summary --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md .
PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE                                                  ERRORS  WARNINGS
----------------------------------------------------------------------
...dules/contrib/edsapi-drupal8-plugin/css/ebsco.css  141     0
...ules/contrib/edsapi-drupal8-plugin/ebsco.info.yml  1       0
...contrib/edsapi-drupal8-plugin/ebsco.libraries.yml  1       0
...odules/contrib/edsapi-drupal8-plugin/ebsco.module  1691    76
...es/contrib/edsapi-drupal8-plugin/lib/EBSCOAPI.php  102     9
...trib/edsapi-drupal8-plugin/lib/EBSCOConnector.php  180     4
...ntrib/edsapi-drupal8-plugin/lib/EBSCODocument.php  795     6
...contrib/edsapi-drupal8-plugin/lib/EBSCORecord.php  70      2
...ntrib/edsapi-drupal8-plugin/lib/EBSCOResponse.php  118     4
...rib/edsapi-drupal8-plugin/lib/sanitizer.class.php  91      7
...b/modules/contrib/edsapi-drupal8-plugin/phpcs.txt  1       0
...b/modules/contrib/edsapi-drupal8-plugin/README.md  0       1
...drupal8-plugin/src/Controller/EbscoController.php  120     10
...rib/edsapi-drupal8-plugin/src/Form/EbscoAdmin.php  38      1
...ntrib/edsapi-drupal8-plugin/src/Form/EBSCOAPI.php  91      9
.../edsapi-drupal8-plugin/src/Form/EBSCODocument.php  151     1
...pi-drupal8-plugin/src/Plugin/Block/EbscoBlock.php  1       3
...ib/edsapi-drupal8-plugin/src/Plugin/ebsco_eds.php  6       0
----------------------------------------------------------------------
A TOTAL OF 3598 ERRORS AND 133 WARNINGS WERE FOUND IN 18 FILES
----------------------------------------------------------------------
PHPCBF CAN FIX 2994 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
@jameswilson jameswilson changed the title Pass PHPCS Pass PHP Code Sniffer Drupal standard Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant