Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] check_outliers() expose 'xi' parameter for OPTICS #785

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

DominiqueMakowski
Copy link
Member

I have a nice new dataset of a questionnaire validation that included attention checks. I have been playing with check_outliers(), and the OPTICS method. Interestingly, the current rule for its threshold that we have didn't work at all, + I had to change xi to actually make it work (hence this PR that allows to do that).

Interestingly though, we typically consider outliers observations with a large distance, but my data shows that people that have failed attention checks (i.e., "objective" outliers) tend to have a low distance:

image

(the logistic model failed ~ distance_optics makes it a significant predictor of failure)

I wouldn't recommend any action for now, maybe we can simply mention this observation (that it is possible that low distances are also problematic) once my paper is published and link to it

@strengejacke
Copy link
Member

Looks good, can be merged, or not?

@DominiqueMakowski
Copy link
Member Author

Yup, it should work! Thanks

@strengejacke strengejacke merged commit cd2e056 into main Dec 4, 2024
4 of 5 checks passed
@strengejacke strengejacke deleted the fix_checkoutliers_xi branch December 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants