Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename at arguments into by #255

Merged
merged 24 commits into from
May 24, 2024
Merged

Rename at arguments into by #255

merged 24 commits into from
May 24, 2024

Conversation

strengejacke
Copy link
Member

@DominiqueMakowski
Copy link
Member

Thanks Daniel :)

@strengejacke
Copy link
Member Author

I hope all relevant code pieces are updated now. Still some failing checks, due to report, where we also need to make changes. Renaming the arguments throughout all packages will cause some uneasiness when submitting all updates to CRAN, I guess ;-)

@strengejacke
Copy link
Member Author

@DominiqueMakowski The examples I removed in this commit are even not working with the current CRAN version of modelbased - it's not related to this PR.

@strengejacke
Copy link
Member Author

This error occurs when ggplot2 is loaded after poorman (https://github.com/easystats/modelbased/actions/runs/9209112782/job/25332884239):

Caused by error:
! cannot xtfrm data frames
Backtrace:
     ▆
  1. └─... %>% summarise(RT = mean(RT))
  2.   └─base::eval(rhs_call, envir = list(. = lhs), enclos = parent.frame())
  3.     └─base::eval(rhs_call, envir = list(. = lhs), enclos = parent.frame())
  4.       ├─poorman::summarise(., RT = mean(RT))
  5.       └─poorman:::summarise.grouped_df(., RT = mean(RT))
  6.         └─poorman:::groups_set(res, groups[-n], group_by_drop_default(.data))
  7.           └─poorman:::calculate_groups(x, groups, drop)
  8.             ├─...[]
  9.             ├─tibble:::`[.tbl_df`(...)
 10.             ├─base::do.call(...)
 11.             └─base (local) `<fn>`(`<tibble[,1]>`, `<tibble[,1]>`)
 12.               └─base::lapply(z, function(x) if (is.object(x)) as.vector(xtfrm(x)) else x)
 13.                 └─base (local) FUN(X[[i]], ...)
 14.                   ├─base::as.vector(xtfrm(x))
 15.                   ├─base::xtfrm(x)
 16.                   └─base::xtfrm.data.frame(x)

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 59.11330% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 36.39%. Comparing base (b4692b9) to head (ec683fd).
Report is 3 commits behind head on main.

Current head ec683fd differs from pull request most recent head aabb649

Please upload reports for the commit aabb649 to get more accurate results.

Files Patch % Lines
R/estimate_slopes.R 16.00% 21 Missing ⚠️
R/get_emmeans.R 68.08% 15 Missing ⚠️
R/visualisation_recipe.estimate_means.R 0.00% 13 Missing ⚠️
R/visualisation_recipe.estimate_slopes.R 0.00% 10 Missing ⚠️
R/get_emtrends.R 70.00% 6 Missing ⚠️
R/visualisation_matrix.R 0.00% 6 Missing ⚠️
R/get_marginaleffects.R 60.00% 4 Missing ⚠️
R/estimate_means.R 66.66% 3 Missing ⚠️
R/estimate_contrasts.R 92.85% 2 Missing ⚠️
R/get_emcontrasts.R 90.47% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   35.96%   36.39%   +0.42%     
==========================================
  Files          25       25              
  Lines        1190     1220      +30     
==========================================
+ Hits          428      444      +16     
- Misses        762      776      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke strengejacke merged commit 5b8eb68 into main May 24, 2024
18 of 29 checks passed
@strengejacke strengejacke deleted the rename_args branch May 24, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants