Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rive animation support #2274

Open
7 tasks
randybascue opened this issue Feb 21, 2024 · 3 comments
Open
7 tasks

Rive animation support #2274

randybascue opened this issue Feb 21, 2024 · 3 comments

Comments

@randybascue
Copy link

randybascue commented Feb 21, 2024

Description

We have plans to utilize Rive for animations in the future.

Screenshots

No response

Figma link

No response

Engineering pre-requisites

  • Rive sign off from eBay VAT/ADR team
  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@ianmcburnie
Copy link
Contributor

ianmcburnie commented Feb 23, 2024

Hmm, isn't this a return to the world of proprietary runtimes and non web standards - a la Flash- which everybody agreed was a bad thing. What am I missing here? Have we considered tools that output SVG or GIF without requiring a run time?

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Mar 20, 2024

One of the main things I'd be concerned about with green lighting Rive, not least from an accessibility perspective:

We have customers shipping full UI with Rive!

https://news.ycombinator.com/item?id=39768500

@ArtBlue
Copy link
Contributor

ArtBlue commented Mar 20, 2024

The runtime library file size, loading roundtrip, requiring js, potential placeholders for async loaded assets, etc. may not matter as much in the world of native apps since apps are bundled and downloaded prior to use and people using apps have a different set of expectations.

On the web things are very different. Everything is more or less a runtime experience. Even bundled assets get impacted at use since inclusion of additional runtimes in bundles impacts page loading speeds. Also, when the runtime is bundled with other assets, all users are impacted, whether they ever encounter a page with an animation or not.

Tools that export animations directly to svg and do not require js are far more preferable. The individual animation svg is a native element and inherently has far more implementation flexibility. It would also not require a runtime that would increase bundle sizes and impact page loading speeds.

Further evaluation may be necessary (the purpose of this issue), but one such tool appears to be https://www.svgator.com/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

6 participants