-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action bar (component name tbd, formerly filter bar) #1927
Comments
Initial passthrough for this seems to me there are some concerns with this component. Questions and concerns:
If we were to build this, the only thing I could see is us building a resizable bar to allow teams to place what they want in there. |
Currently we present filters / section level controls in a lot of various ways across the experience. This is a framework a consistent presentation for designer to use. Yes a lot of this is up to domains. |
Lets have a kickoff with this, need some questions answered. |
Probably will not do this issue. Will keep it open for now. |
Had an initial kickoff. We will do the layout for this. Still waiting on updated design treatment |
We will need to discuss what parts need to be built by skin and be generic enough to be a skin component. |
I added back the blocked discussion tag because we need to build other internal components first, and we haven't begun to talk about those yet. See Andrew's comment from June 27. |
Final Design & Specs under Action Bar — https://www.figma.com/design/8Tkj9vHE3BOHoWjiZ1pNt2/Playbook-2.0-%2F-Patterns?node-id=203-59654&t=x4gsBWK7B6tQwpdp-1 |
For start need to investigate on how to do the responsive layout. |
❗ An issue to track:
|
@ArtBlue updated the documentation to address the visual affordance for when the filter bar has scrolling. |
@hej-wesley , I'm not seeing it in the Figma. Is there some new Figma? Can you paste a screenshot along with the correct Figma? |
Thanks for that |
@hej-wesley , thanks for the quick turnaround. Just so we're all on the same page, since our page grid has gutters, the overflow will have spacing to the left and right. The design doesn't account for that as it is going all the way to the page edges. Just letting your know how the final implementation will look. |
Was chatting a bit with @namtheho today about filter bars and just caught up on this thread. A few thoughts:
@ArtBlue, are the page grid gutters dictated by Skin or the containing app? If Skin, perhaps there could be two CSS variants of this component, one that's aware of gutters and one that isn't. The gutter-aware variant could use negative margins to offset the gutter and go full width. @hej-wesley, does the overflow gradient only apply to the end of the list, or also the beginning once the list is scrolled? In other words, should there be a gradient on the left side once the user has scrolled the initial list elements out of view? From the spec, it looks like just the right side, but wanted to confirm. |
@cordeliadillon , as far as the gutters go, it's definitely technically feasible. However, to achieve it we would need to absolute position the filter bar - a strategy we use very sparingly as it pulls the element out of the natural page flow. The best use case for As for the gradient, I don't personally think we need one on the left. Since all pages start with the content aligned left for LTR, we just need an affordance for scrolling forward. Once a user does scroll forward they already know they can scroll back. We'd just need to do the opposite for RTL. |
To recap on the v1 release:
We'll follow this up with a v2 spike on the scrolling issue discovered during the build |
A filter bar is a collection of components that provide controls to give users more agency over their content or data sets.
This page covers principles, controls, behavior scaling for build a filter bar.
Figma LINK
The text was updated successfully, but these errors were encountered: