Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK requests from browser to envd blocked via CORS #409

Open
ValentaTomas opened this issue Jul 12, 2024 · 2 comments
Open

SDK requests from browser to envd blocked via CORS #409

ValentaTomas opened this issue Jul 12, 2024 · 2 comments
Labels
bug Something isn't working sdk Improvements or additions to SDKs

Comments

@ValentaTomas
Copy link
Member

ValentaTomas commented Jul 12, 2024 •
edited
Loading

Envd seems to be blocking requests from browser because of CORS. The first OPTIONS request is successful but the next (start process) request fails on cors with no response headers.

We are setting CORS in envd server, but it looks like there still might be a problem.
@ValentaTomas ValentaTomas added the bug Something isn't working label Jul 12, 2024
@ValentaTomas
Copy link
Member Author

This might be a problem with the SDK and not the envd server because a direct fetch call to the envd server seems to work.

@ValentaTomas ValentaTomas transferred this issue from e2b-dev/infra Jul 21, 2024
@ValentaTomas ValentaTomas added the sdk Improvements or additions to SDKs label Jul 22, 2024
@ValentaTomas
Copy link
Member Author

This is a problem with either a wrong configuration of API client, envd client, and ConnectRpc transport (cors vs no-cors in the SDK) or with Nginx proxies that might be removing some headers (e2b-dev/infra#94).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working sdk Improvements or additions to SDKs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ValentaTomas