Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable evaluation results filters #2232

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Customizable evaluation results filters #2232

wants to merge 46 commits into from

Commits on Nov 25, 2024

  1. alle changes ohne tests

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ffcc5ed View commit details
    Browse the repository at this point in the history

  2. tests jetzt hinzugefügt mit neuer struktur (schon wieder) test_tools.… 

    …py müssen wir uns nochmal anschauen, da failed noch ein test
    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5314120 View commit details
    Browse the repository at this point in the history

  3. minimal_test_data_results.json geändert, ist jetzt cooler, außerdem t… 

    …est_tools zusammengeführt, jetzt alles clean
    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ee4f6e8 View commit details
    Browse the repository at this point in the history

  4. vscode hat komische dinge in results_evaluation_detail.html gemacht, … 

    …aber jetzt geht wieder
    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    de166d3 View commit details
    Browse the repository at this point in the history

  5. button description

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    66f3907 View commit details
    Browse the repository at this point in the history

  6. correct redirect link when exporting as manager

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fc44043 View commit details
    Browse the repository at this point in the history

  7. tests shortened, new test for contributor

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4c9e178 View commit details
    Browse the repository at this point in the history

  8. added tests for delegates for contributor and responsible in contribu… 

    …tor and responsible test classes
    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    8d69b5d View commit details
    Browse the repository at this point in the history

  9. test

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9460ceb View commit details
    Browse the repository at this point in the history

  10. changed contributor test

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b087e3a View commit details
    Browse the repository at this point in the history

  11. changed tests again, trying to satisfy linter

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0b83e29 View commit details
    Browse the repository at this point in the history

  12. linter happy now :)

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a95179a View commit details
    Browse the repository at this point in the history

  13. Update evap/results/templates/results_evaluation_detail.html 

    Co-authored-by: Johannes Wolf <[email protected]>
    @ybrnr @janno42
    ybrnr and janno42 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ef39d52 View commit details
    Browse the repository at this point in the history

  14. Update evap/results/templates/results_evaluation_detail.html 

    Co-authored-by: Johannes Wolf <[email protected]>
    @ybrnr @janno42
    ybrnr and janno42 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    852b5c0 View commit details
    Browse the repository at this point in the history

  15. Update evap/results/templates/results_evaluation_detail.html 

    Co-authored-by: Johannes Wolf <[email protected]>
    @ybrnr @janno42
    ybrnr and janno42 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b627a6d View commit details
    Browse the repository at this point in the history

  16. Update evap/results/templates/results_evaluation_detail.html 

    Co-authored-by: Johannes Wolf <[email protected]>
    @ybrnr @janno42
    ybrnr and janno42 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c232e32 View commit details
    Browse the repository at this point in the history

  17. Update evap/results/templates/results_evaluation_detail.html 

    Co-authored-by: Johannes Wolf <[email protected]>
    @ybrnr @janno42
    ybrnr and janno42 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    98d3aea View commit details
    Browse the repository at this point in the history

  18. Apply suggestions from code review 

    Co-authored-by: Johannes Wolf <[email protected]>
    @ybrnr @janno42
    ybrnr and janno42 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9c66a38 View commit details
    Browse the repository at this point in the history

  19. user with Textanswervisibility OWN cannot see general buttons

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1214184 View commit details
    Browse the repository at this point in the history

  20. standard values for button parameters defined as suggested by janno

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d0c96cf View commit details
    Browse the repository at this point in the history

  21. removed old comments

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    012f4be View commit details
    Browse the repository at this point in the history

  22. added small test for contributor default view

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4489254 View commit details
    Browse the repository at this point in the history

  23. new can_textanswer_be_seen_by structure

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3da2c2c View commit details
    Browse the repository at this point in the history

  24. disable general view buttons if user cannot view general textanswers

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2b5dfbb View commit details
    Browse the repository at this point in the history

  25. disable filter buttons, if user cannot see general/contributor textan… 

    …swers
    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    03dc670 View commit details
    Browse the repository at this point in the history

  26. enum for differnet button filter options

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    026b116 View commit details
    Browse the repository at this point in the history

  27. fixed imports

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1143d91 View commit details
    Browse the repository at this point in the history

  28. started to change test structure... (again)

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d8ce6ff View commit details
    Browse the repository at this point in the history

  29. tests weiter geändert

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2f5662a View commit details
    Browse the repository at this point in the history

  30. changed some tests

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4ebb82c View commit details
    Browse the repository at this point in the history

  31. manager test now with staff mode and removed old tests

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f0d7015 View commit details
    Browse the repository at this point in the history

  32. removed unnecessary test

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6fd71cf View commit details
    Browse the repository at this point in the history

  33. made the active conitions for buttons use proper Enums

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    01f8efd View commit details
    Browse the repository at this point in the history

  34. added helper test to see if buttons are disabled

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f48e5c4 View commit details
    Browse the repository at this point in the history

  35. buttons cannot be active, when disabled; created next_step file to tr… 

    …ack on what problem we are working atm
    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    cf9bcce View commit details
    Browse the repository at this point in the history

  36. added comments in code to work on next time

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    eb0c654 View commit details
    Browse the repository at this point in the history

  37. reformatted files

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2e3b187 View commit details
    Browse the repository at this point in the history

  38. (partially) fixed display of button groups 

    made the can_see_general_textanswers and the contributor counterpart also consider the represtened users
    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    485f997 View commit details
    Browse the repository at this point in the history

  39. changed filter logic for general

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d897490 View commit details
    Browse the repository at this point in the history

  40. added prints for testing

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    31d575f View commit details
    Browse the repository at this point in the history

  41. added comment 

    make difference between remove_textanswers_that_the_user_must_not_see and can_textanswer_be_seen_by clearer for the future
    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3dc87f1 View commit details
    Browse the repository at this point in the history

  42. disable textanswer buttons 

    when users cannot or should not click specific textanswer buttons (because it does not make sense) they should still be there for consistency but should be disabled
    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c81b84b View commit details
    Browse the repository at this point in the history

  43. linter happy now :)

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c9c224a View commit details
    Browse the repository at this point in the history

  44. removed comments

    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c9ffbef View commit details
    Browse the repository at this point in the history

  45. cleanup 

    removed unnecessary comment and fixed HTML broken indentations and whitespaces
    @jooooosef @ybrnr
    jooooosef authored and ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c76acae View commit details
    Browse the repository at this point in the history

  46. removed txt file

    @ybrnr
    ybrnr committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c852a04 View commit details
    Browse the repository at this point in the history