Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable evaluation results filters #1786

Open
janno42 opened this issue Aug 1, 2022 · 6 comments · May be fixed by #2232
Open

Customizable evaluation results filters #1786

janno42 opened this issue Aug 1, 2022 · 6 comments · May be fixed by #2232
Assignees
@Tillbtn @ybrnr @jooooosef
Labels
[C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Minor Minor priority

Comments

@janno42
Copy link
Member

janno42 commented Aug 1, 2022

Currently, an evaluation's results page can be viewed as "Public" (shows results that are visible for everyone logged in), "Own" (shows all results that are visible for the current user), and "Export" (shows all results for general questions and the results for the current user).

This should be changed to two customizable filters which can be selected via switch button groups (two button groups placed below each other in the top right of the page):

  • General results (only visible if current user can see text answers for general questions (reviewers, responsibles of this evaluation, contributors in this evaluation where TextAnswerVisibility is set to GENERAL_TEXTANSWERS, and delegates of such responsibles and contributors))
    • Show text answers
    • Hide text answers
  • Contributor results (only visible if current user is reviewer, contributor in this evaluation, or delegate of such a contributor)
    • Show text answers
    • Hide text answers
    • Only my results (only visible if current user is contributor in this evaluation and for staff users who opened this view via the contributor's profile like in the current "Export" view)
@janno42 janno42 added [C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Minor Minor priority labels Aug 1, 2022
@richardebeling
Copy link
Member

@Tillbtn @ybrnr @JosefValentin2004 What's your status here, do you want to continue working on this or can we unassign/reassign?

@jooooosef
Copy link
Collaborator

@richardebeling No, I wanna continue. We are almost done anyways but Prüfungsphase :(

@jooooosef
Copy link
Collaborator

We now have the changed buttons, with:
general: full (with textanswers), ratings (without textanswers) for the general results
contributor: full (all text answers from all contributors), ratings (no text answers from any contributors) and personal (show ALL textanswers regarding that contributor).

Should personal also include the so called private textanswers (regarding the contributor)? Before when there was only one set options with public, full and export, in export you couldnt see the private text answers.

@janno42
Copy link
Member Author

janno42 commented Apr 22, 2024

Should personal also include the so called private textanswers (regarding the contributor)? Before when there was only one set options with public, full and export, in export you couldnt see the private text answers.

Private text answers should be shown when selecting "personal" - the respective tests need to be changed.

@richardebeling
Copy link
Member

@jooooosef Can you push your current state to some branch and create a pull request for that (possibly marked WIP if you want) so we can take a first look at the code and especially the tests?

@jooooosef jooooosef linked a pull request Jun 24, 2024 that will close this issue
Open
@jooooosef
Copy link
Collaborator

@richardebeling I just did, marked as draft. I started to change the tests a little but only did it for students so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tillbtn Tillbtn

@ybrnr ybrnr

@jooooosef jooooosef

Labels
[C] Backend Focuses on backend implementation [C] Frontend Focuses on frontend implementation [P] Minor Minor priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Customizable evaluation results filters ybrnr/EvaP
5 participants
@janno42 @richardebeling @Tillbtn @ybrnr @jooooosef