Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if isConsented, don't re-prompt for optional permissions #1185

Merged

Conversation

JGreenlee
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.44%. Comparing base (6d1fcad) to head (03dd1f0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
www/js/usePermissionStatus.ts 0.00% 2 Missing ⚠️
www/js/onboarding/onboardingHelper.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1185   +/-   ##
=======================================
  Coverage   29.44%   29.44%           
=======================================
  Files         122      122           
  Lines        4915     4914    -1     
  Branches     1080     1124   +44     
=======================================
  Hits         1447     1447           
+ Misses       3468     3465    -3     
- Partials        0        2    +2     
Flag Coverage Δ
unit 29.44% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
www/js/onboarding/onboardingHelper.ts 43.24% <0.00%> (ø)
www/js/usePermissionStatus.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@shankari shankari merged commit ab90f8a into e-mission:master Oct 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tasks completed
Development

Successfully merging this pull request may close these issues.

2 participants