Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 🌐 Jan. 2024 Translation Cleanup #1040

Closed
5 tasks done
Abby-Wheelis opened this issue Jan 2, 2024 · 4 comments
Closed
5 tasks done

🧹 🌐 Jan. 2024 Translation Cleanup #1040

Abby-Wheelis opened this issue Jan 2, 2024 · 4 comments

Comments

@Abby-Wheelis
Copy link
Member

Abby-Wheelis commented Jan 2, 2024

I noticed a couple of weeks ago that there was at least some small part of the app that was not translated properly, at least on the branch that I was viewing, which led me to run some comparisons between our phone and translate repos to check and see if translations are up to date or not. What I've noticed:

  • translate/master has all of the multilabel translations, phone/master does not, but phone/service_rewrite_2023 does
  • phone/service_rewrite_2023 has some error messages that translate/master does not
  • using 'translate/master' with 'phone/master', on the dashboard, a large portion of the active minutes card is not translated
  • same as above, the labels are not translated on the third row of cards, and are not translated on the label screen (could this be the opcode I'm using?)
  • On the label screen, the dates are not translated "Mon January 1"

For the multilabels: if I'm remembering correctly, we moved to using either project-specific or default custom label lists that have translations associated with them, so I think we should remove the translations from translate, but @sebastianbarry or @JGreenlee please correct me if I'm mistaken

For the error messages, I think we can go ahead and add those to translate, or at least have the PR prepared, so when service_rewrite_2023 is fully tested and merged we have them ready for production

@Abby-Wheelis
Copy link
Member Author

Once I worked with service_rewrite_2023 the lack of multilabels being translated was resolved, and internationalizing the "Active Minutes" cards was quite simple, that screen is now translated:

I've also added the translations of the error messages

left: address the dates on the label card and removing extra multilabel translations

@Abby-Wheelis
Copy link
Member Author

fixed the date issues on the label screen by updating from

t.format('ddd LL');

to

t.locale(i18next.language).format('ddd LL');

Note: I just did this in one place in diaryHelper.ts so far, we should determine if there are any other places that would show in other configurations (ie surveys) or data scenarios (ie multiday) that need this change.

@Abby-Wheelis
Copy link
Member Author

These changes are handled by: translate #52 and phone #1121

@Abby-Wheelis
Copy link
Member Author

These changes have been merged, so this issue can be closed

@github-project-automation github-project-automation bot moved this from Issues being worked on to Tasks completed in OpenPATH Tasks Overview Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant