Big refactoring code and tests #18
Conversation
Converts statements of the form
'%s' % foo
to statements of the form
'{0}'.format(foo)
This completes removal of code necessary for Python 2.5 support; Flask no longer support Python 2.5.
Tox Fix log-capture
|
Thanks @klinkin. I've made a couple comments on the two issues, but other than that it mostly looks good. The |
|
Will chip in tomorrow, if time permits 😃 |
|
Can we revert the |
| logger.debug("All valid files: %s" % all_files) | ||
| conn = S3Connection(user, password) # connect to s3 | ||
| for (static_folder, static_url_loc), files in all_files.iteritems(): | ||
| logger.debug('{0} valid files in folder "{1}" with local url "{2}"'.format(len(files), static_folder, static_url_loc)) |
There was a problem hiding this comment.
Can we get this down to 80 chars please?
|
No idea what it is, so I'll defer to your judgement. On 30 Jan 2014, at 22:15, Erik Taubeneck [email protected] wrote:
|
Revert using unittest
Revert from nose2 to nose
…to new_features
|
can this be merged @eriktaubeneck ? |
|
Sorry, let this one slip. I'm still not a fan of adding the |
|
@klinkin closing this, but happy to re-open if @eriktaubeneck's concerns are addressed. |
|
@klinkin if there is a good reason for the |
All existing tests are passed.