You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey Martin,
Thank you very much for the feedback.
I can verify, that without a footer, critical data would be missing.
This Github project is intended as a template for the FirstSpirit reference project 'Smart Living'.
The solution that works for 'Smart Living' does not have to (and cannot) work for every FirstSpirit project.
So usually customers and partners work on forks of this project.
If there may be page layouts in your project that are displayed without a footer, that problem can be solved locally.
On our side we have no capacity to improve this situation, even if we like the idea.
If you would like to have the problem solved in the PWA template, we would appreciate it if you could send us a PR for this.
When creating a page without a footer, useProjectProperties always returned undefined.
After some investigating it turns out that critical code is executed inside of the footer template.
I think it would be a good idea to uncouple this from a layout component and move it to some place that is less likely to be removed from pages.
crownpeak-pwa-template/components/AppLayout/Footer.vue
Line 38 in 62f8d17
Regards,
Martin Freisen
The text was updated successfully, but these errors were encountered: