Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move calling fetchProjectProperties to a non-template location #133

Open
mfr-comspace opened this issue Jan 17, 2024 · 1 comment
Open

Comments

@mfr-comspace
Copy link
Collaborator

When creating a page without a footer, useProjectProperties always returned undefined.

After some investigating it turns out that critical code is executed inside of the footer template.

I think it would be a good idea to uncouple this from a layout component and move it to some place that is less likely to be removed from pages.

const projectProperties = await fetchProjectProperties(activeLocale.value!)

Regards,
Martin Freisen

@nico-mcalley
Copy link
Collaborator

Hey Martin,
Thank you very much for the feedback.
I can verify, that without a footer, critical data would be missing.

This Github project is intended as a template for the FirstSpirit reference project 'Smart Living'.
The solution that works for 'Smart Living' does not have to (and cannot) work for every FirstSpirit project.
So usually customers and partners work on forks of this project.
If there may be page layouts in your project that are displayed without a footer, that problem can be solved locally.

On our side we have no capacity to improve this situation, even if we like the idea.
If you would like to have the problem solved in the PWA template, we would appreciate it if you could send us a PR for this.

Kind regards
Nico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants