Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial library's old version doesn't handle interrupted system calls #3

Open
joonas-fi opened this issue May 20, 2021 · 2 comments
Open

Comments

@joonas-fi
Copy link

Problem

Get interrupted system call errors from ZNP ReadFrame() failing.

Serial library is at an old version:

go.bug.st/serial.v1 v0.0.0-20180827123349-5f7892a7bb45

This old version seems to bypass Go's regular OS I/O interfaces (that would take EINTR into account), and doesn't take EINTR into account at all.

Fix

Update to new version, it correctly retries on EINTR.

@dyrkin
Copy link
Owner

dyrkin commented May 20, 2021

Hi @joonas-fi,
Unfortunately, I have no time to support it for now. Do you want me to add you to contributors and you'll fix it by yourself?
Or of course, you can fork the project and fix it on your side.

@joonas-fi
Copy link
Author

No worries, and thank you for your projects! I mainly posted these issues to help users of this project :)

I've actually already forked most of these projects and done some major work on them, I will credit you and it will be open sourced as part of my home automation hub project https://github.com/function61/hautomo

@joonas-fi
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants