Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not remove manual monitoring when found results #29

Open
atais opened this issue Feb 16, 2022 · 2 comments
Open

do not remove manual monitoring when found results #29

atais opened this issue Feb 16, 2022 · 2 comments

Comments

@atais
Copy link
Contributor

atais commented Feb 16, 2022

i think the monitoring should be removed only when you accept one of the proposals?
sometimes you want to keep looking. or there could be extra button - found x,y,z, do you want to stop looking?
wdyt?

i believe i could try to fix that but since i dont know the codebase very well it may take a while

@dyrkin
Copy link
Owner

dyrkin commented Feb 21, 2022

There are time periods when Luxmed throws out a lot of new time slots, sometimes at night. If the bot didn't cancel monitoring then it will be receiving almost the same list all over the night sending it to a user. Of course, I can check what was already sent to the user but in that case, I need to store this state somehow what I'm trying to avoid as much as possible.
Second: I try to make as less calls to Luxmed API as possible to make it possible not to be banned as long as possible.

feel free to share your thoughts on how to do this neatly

@atais
Copy link
Contributor Author

atais commented Feb 22, 2022

There are time periods when Luxmed throws out a lot of new time slots, sometimes at night. If the bot didn't cancel monitoring then it will be receiving almost the same list all over the night sending it to a user.

wow. smart 👍

ok so it could be the other way round. we need a button like: "keep looking" which would recreate the monitoring with existing settings. otherwise it would be removed like it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants